From 069352fb0f979d0b556aaff388c464139aa930ee Mon Sep 17 00:00:00 2001
From: Peter Pfeufer <info@ppfeufer.de>
Date: Sat, 1 Jun 2024 12:01:44 +0200
Subject: [PATCH] [FIX] Switch to bottom margin instead of top/bottom padding

This is the much more commonly used approach.
---
 .../templates/authentication/dashboard_characters.html        | 2 +-
 .../templates/authentication/dashboard_groups.html            | 2 +-
 allianceauth/optimer/templates/optimer/dashboard.ops.html     | 2 +-
 .../templates/allianceauth/admin-status/esi_check.html        | 2 +-
 .../templates/allianceauth/admin-status/overview.html         | 4 ++--
 .../timerboard/templates/timerboard/dashboard.timers.html     | 2 +-
 docs/development/custom/framework/templates.md                | 2 +-
 7 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/allianceauth/authentication/templates/authentication/dashboard_characters.html b/allianceauth/authentication/templates/authentication/dashboard_characters.html
index 68b046a8..3560210f 100644
--- a/allianceauth/authentication/templates/authentication/dashboard_characters.html
+++ b/allianceauth/authentication/templates/authentication/dashboard_characters.html
@@ -1,5 +1,5 @@
 {% load i18n %}
-<div id="aa-dashboard-panel-characters" class="col-12 col-xl-8 py-2">
+<div id="aa-dashboard-panel-characters" class="col-12 col-xl-8 mb-3">
     <div class="card h-100">
         <div class="card-body">
             {% translate "Characters" as widget_title %}
diff --git a/allianceauth/authentication/templates/authentication/dashboard_groups.html b/allianceauth/authentication/templates/authentication/dashboard_groups.html
index 6191ed23..d7d3c3b7 100644
--- a/allianceauth/authentication/templates/authentication/dashboard_groups.html
+++ b/allianceauth/authentication/templates/authentication/dashboard_groups.html
@@ -1,5 +1,5 @@
 {% load i18n %}
-<div id="aa-dashboard-panel-membership" class="col-12 col-xl-4 py-2">
+<div id="aa-dashboard-panel-membership" class="col-12 col-xl-4 mb-3">
     <div class="card h-100">
         <div class="card-body">
             {% translate "Membership" as widget_title %}
diff --git a/allianceauth/optimer/templates/optimer/dashboard.ops.html b/allianceauth/optimer/templates/optimer/dashboard.ops.html
index a406a76f..b9e1d418 100644
--- a/allianceauth/optimer/templates/optimer/dashboard.ops.html
+++ b/allianceauth/optimer/templates/optimer/dashboard.ops.html
@@ -1,7 +1,7 @@
 {% load i18n %}
 {% load evelinks %}
 
-<div class="col-12 py-2">
+<div class="col-12 mb-3">
     <div class="card h-100">
         <div class="card-body">
             {% translate "Upcoming Fleets" as widget_title %}
diff --git a/allianceauth/templates/allianceauth/admin-status/esi_check.html b/allianceauth/templates/allianceauth/admin-status/esi_check.html
index cea4ef19..9c7f1605 100644
--- a/allianceauth/templates/allianceauth/admin-status/esi_check.html
+++ b/allianceauth/templates/allianceauth/admin-status/esi_check.html
@@ -23,7 +23,7 @@
             console.log("ESI Check: ", JSON.stringify(responseJson, null, 2));
 
             const status = responseJson.status;
-            if (status != 200) {
+            if (status !== 200) {
                 elemCode.textContent = status
                 elemMessage.textContent = responseJson.data.error;
                 new bootstrap.Collapse(elemCard, {
diff --git a/allianceauth/templates/allianceauth/admin-status/overview.html b/allianceauth/templates/allianceauth/admin-status/overview.html
index 17925aae..a8de1aca 100644
--- a/allianceauth/templates/allianceauth/admin-status/overview.html
+++ b/allianceauth/templates/allianceauth/admin-status/overview.html
@@ -2,7 +2,7 @@
 {% load humanize %}
 
 {% if notifications %}
-    <div id="aa-dashboard-panel-admin-notifications" class="col-12 pb-2">
+    <div id="aa-dashboard-panel-admin-notifications" class="col-12 mb-3">
         <div class="card">
             <div class="card-body">
                 {% translate "Alliance Auth Notifications" as widget_title %}
@@ -46,7 +46,7 @@
     </div>
 {% endif %}
 
-<div class="col-12 py-2">
+<div class="col-12 mb-3">
     <div class="card">
         <div class="card-body row">
             <div id="aa-dashboard-panel-software-version" class="col-xl-6 col-lg-12 col-md-12 col-sm-12">
diff --git a/allianceauth/timerboard/templates/timerboard/dashboard.timers.html b/allianceauth/timerboard/templates/timerboard/dashboard.timers.html
index cf8c7916..4b6d9a5a 100644
--- a/allianceauth/timerboard/templates/timerboard/dashboard.timers.html
+++ b/allianceauth/timerboard/templates/timerboard/dashboard.timers.html
@@ -1,7 +1,7 @@
 {% load i18n %}
 {% load evelinks %}
 
-<div class="col-12 py-2">
+<div class="col-12 mb-3">
     <div class="card h-100">
         <div class="card-body">
             {% translate "Upcoming Timers" as widget_title %}
diff --git a/docs/development/custom/framework/templates.md b/docs/development/custom/framework/templates.md
index 88157353..c989e53e 100644
--- a/docs/development/custom/framework/templates.md
+++ b/docs/development/custom/framework/templates.md
@@ -35,7 +35,7 @@ To ensure the dashboard widgets have a unified style, we provide a template part
 To use it, you can use the following code in your dashboard widget template:
 
 ```django
-<div id="my-app-dashboard-widget" class="col-12 py-2">
+<div id="my-app-dashboard-widget" class="col-12 mb-3">
     <div class="card">
         <div class="card-body">
             {% translate "My Widget Title" as widget_title %}