From 0af188c6ab4b24d9245257a492541c12b3009f36 Mon Sep 17 00:00:00 2001 From: colcrunch Date: Wed, 29 Aug 2018 21:28:14 -0400 Subject: [PATCH] Disallow applying to groups the user is already a member of --- allianceauth/groupmanagement/views.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/allianceauth/groupmanagement/views.py b/allianceauth/groupmanagement/views.py index e0adeff2..bc901a6f 100755 --- a/allianceauth/groupmanagement/views.py +++ b/allianceauth/groupmanagement/views.py @@ -291,6 +291,12 @@ def group_request_add(request, group_id): (request.user, group_id)) messages.warning(request, _("You cannot join that group")) return redirect('groupmanagement:groups') + if group in request.user.groups.all(): + # User is already a member of this group. + logger.warning("User %s attempted to join group id %s but they are already a member." % + (request.user, group_id)) + messages.warning(request, "You are already a member of that group.") + return redirect('groupmanagement:groups') if not request.user.has_perm('groupmanagement.request_groups') and not group.authgroup.public: # Does not have the required permission, trying to join a non-public group logger.warning("User %s attempted to join group id %s but it is not a public group" %