The Great Services Refactor (#594)

* Hooks registration, discovery and retrieval module

Will discover @hooks.register decorated functions inside
the auth_hooks module in any installed django app.

* Class to register modular service apps

* Register service modules URLs

* Example service module

* Refactor services into modules

Each service type has been split out into its own django app/module. A
hook mechanism is provided to register a subclass of the ServiceHook
class. The modules then overload functions defined in ServiceHook as
required to provide interoperability with alliance auth. Service modules
provide their own urls and views for user registration and account
management and a partial template to display on the services page. Where
possible, new modules should provide their own models for local data
storage.

* Added menu items hooks and template tags

* Added menu item hook for broadcasts

* Added str method to ServicesHook

* Added exception handling to hook iterators

* Refactor mumble migration and table name

Upgrading will require `migrate mumble --fake-initial` to be run first
and then `migrate mumble` to rename the table.

* Refactor teamspeak3 migration and rename table

Upgrading will require `migrate teamspeak3 --fake-initial`

* Added module models and migrations for refactoring AuthServicesInfo

* Migrate AuthServiceInfo fields to service modules models

* Added helper for getting a users main character

* Added new style celery instance

* Changed Discord from AuthServicesInfo to DiscordUser model

* Switch celery tasks to staticmethods

* Changed Discourse from AuthServicesInfo to DiscourseUser model

* Changed IPBoard from AuthServicesInfo to IpboardUser model

* Changed Ips4 from AuthServicesInfo to Ips4User model

Also added disable service task.

This service still needs some love though. Was always missing a
deactivate services hook (before refactoring) for reasons I'm unsure of
so I'm reluctant to add it without knowing why.

* Changed Market from AuthServicesInfo to MarketUser model

* Changed Mumble from AuthServicesInfo to MumbleUser model

Switched user foreign key to one to one relationship.
Removed implicit password change on user exists.
Combined regular and blue user creation.

* Changed Openfire from AuthServicesInfo to OpenfireUser model

* Changed SMF from AuthServicesInfo to SmfUser model

Added disable task

* Changed Phpbb3 from AuthServicesInfo to Phpbb3User model

* Changed XenForo from AuthServicesInfo to XenforoUser model

* Changed Teamspeak3 from AuthServicesInfo to Teamspeak3User model

* Remove obsolete manager functions

* Standardise URL format

This will break some callback URLs
Discord changes from /discord_callback/ to /discord/callback/

* Removed unnecessary imports

* Mirror upstream decorator change

* Setup for unit testing

* Unit tests for discord service

* Added add main character helper

* Added Discourse unit tests

* Added Ipboard unit tests

* Added Ips4 unit tests

* Fix naming of market manager, switch to use class methods

* Remove unused hook functions

* Added market service unit tests

* Added corp ticker to add main character helper

* Added mumble unit tests

* Fix url name and remove namespace

* Fix missing return and add missing URL

* Added openfire unit tests

* Added missing return

* Added phpbb3 unit tests

* Fix SmfManager naming inconsistency and switch to classmethods

* Added smf unit tests

* Remove unused functions, Added missing return

* Added xenforo unit tests

* Added missing return

* Fixed reference to old model

* Fixed error preventing groups from syncing on reset request

* Added teamspeak3 unit tests

* Added nose as test runner and some test settings

* Added package requirements for running tests

* Added unit tests for services signals and tasks

* Remove unused tests file

* Fix teamspeak3 service signals

* Added unit tests for teamspeak3 signals

Changed other unit tests setUp to inert signals

* Fix password gen and hashing python3 compatibility

Fixes #630

Adds unit tests to check the password functions run on both platforms.

* Fix unit test to not rely on checking url params

* Add Travis CI settings file

* Remove default blank values from services models

* Added dynamic user model admin actions for syncing service groups

* Remove unused search fields

* Add hook function for syncing nicknames

* Added discord hook for sync nickname

* Added user admin model menu actions for sync nickname hook

* Remove obsolete code

* Rename celery config app to avoid package name clash

* Added new style celerybeat schedule configuration

periodic_task decorator is depreciated

* Added string representations

* Added admin pages for services user models

* Removed legacy code

* Move link discord button to correct template

* Remove blank default fields from example model

* Disallow empty django setting

* Fix typos

* Added coverage configuration file

* Add coverage and coveralls to travis config

Should probably use nose's built in coverage, but this works for now.

* Replace AuthServicesInfo get_or_create instances with get

Reflects upstream changes to AuthServicesInfo behaviour.

* Update mumble user table name

* Split out mumble authenticator requirements

zeroc-ice seems to cause long build times on travis-ci and isn't
required for the core projects functionality or testing.

services/modules/smf/admin.py

@@ -0,0 +1,10 @@
+from __future__ import unicode_literals
+from django.contrib import admin
+from .models import SmfUser
+
+
+class SmfUserAdmin(admin.ModelAdmin):
+        list_display = ('user', 'username')
+        search_fields = ('user__username', 'username')
+
+admin.site.register(SmfUser, SmfUserAdmin)

services/modules/smf/apps.py

@@ -0,0 +1,7 @@
+from __future__ import unicode_literals
+
+from django.apps import AppConfig
+
+
+class SmfServiceConfig(AppConfig):
+    name = 'smf'

services/modules/smf/auth_hooks.py

@@ -0,0 +1,68 @@
+from __future__ import unicode_literals
+
+from django.conf import settings
+from django.template.loader import render_to_string
+
+from services.hooks import ServicesHook
+from alliance_auth import hooks
+
+from .urls import urlpatterns
+from .tasks import SmfTasks
+
+import logging
+
+logger = logging.getLogger(__name__)
+
+
+class SmfService(ServicesHook):
+    def __init__(self):
+        ServicesHook.__init__(self)
+        self.name = 'smf'
+        self.urlpatterns = urlpatterns
+        self.service_url = settings.SMF_URL
+
+    @property
+    def title(self):
+        return 'SMF Forums'
+
+    def delete_user(self, user, notify_user=False):
+        logger.debug('Deleting user %s %s account' % (user, self.name))
+        return SmfTasks.delete_user(user, notify_user=notify_user)
+
+    def validate_user(self, user):
+        logger.debug('Validating user %s %s account' % (user, self.name))
+        if SmfTasks.has_account(user) and not self.service_active_for_user(user):
+            self.delete_user(user)
+
+    def update_groups(self, user):
+        logger.debug('Updating %s groups for %s' % (self.name, user))
+        if SmfTasks.has_account(user):
+            SmfTasks.update_groups.delay(user.pk)
+
+    def update_all_groups(self):
+        logger.debug('Update all %s groups called' % self.name)
+        SmfTasks.update_all_groups.delay()
+
+    def service_enabled_members(self):
+        return settings.ENABLE_AUTH_SMF or False
+
+    def service_enabled_blues(self):
+        return settings.ENABLE_BLUE_SMF or False
+
+    def render_services_ctrl(self, request):
+        urls = self.Urls()
+        urls.auth_activate = 'auth_activate_smf'
+        urls.auth_deactivate = 'auth_deactivate_smf'
+        urls.auth_reset_password = 'auth_reset_smf_password'
+        urls.auth_set_password = 'auth_set_smf_password'
+        return render_to_string(self.service_ctrl_template, {
+            'service_name': self.title,
+            'urls': urls,
+            'service_url': self.service_url,
+            'username': request.user.smf.username if SmfTasks.has_account(request.user) else ''
+        }, request=request)
+
+
+@hooks.register('services_hook')
+def register_service():
+    return SmfService()

services/modules/smf/manager.py

@@ -0,0 +1,267 @@
+from __future__ import unicode_literals
+import random
+import string
+import calendar
+from datetime import datetime
+import hashlib
+import logging
+import re
+
+from django.db import connections
+from django.conf import settings
+
+logger = logging.getLogger(__name__)
+
+
+class SmfManager:
+    def __init__(self):
+        pass
+
+    SQL_ADD_USER = r"INSERT INTO smf_members (member_name, passwd, email_address, date_registered, real_name," \
+                   r" buddy_list, message_labels, openid_uri, signature, ignore_boards) " \
+                   r"VALUES (%s, %s, %s, %s, %s, 0, 0, 0, 0, 0)"
+
+    SQL_DEL_USER = r"DELETE FROM smf_members where member_name = %s"
+
+    SQL_DIS_USER = r"UPDATE smf_members SET email_address = %s, passwd = %s WHERE member_name = %s"
+
+    SQL_USER_ID_FROM_USERNAME = r"SELECT id_member from smf_members WHERE member_name = %s"
+
+    SQL_ADD_USER_GROUP = r"UPDATE smf_members SET additional_groups = %s WHERE id_member = %s"
+
+    SQL_GET_GROUP_ID = r"SELECT id_group from smf_membergroups WHERE group_name = %s"
+
+    SQL_ADD_GROUP = r"INSERT INTO smf_membergroups (group_name,description) VALUES (%s,%s)"
+
+    SQL_UPDATE_USER_PASSWORD = r"UPDATE smf_members SET passwd = %s WHERE member_name = %s"
+
+    SQL_REMOVE_USER_GROUP = r"UPDATE smf_members SET additional_groups = %s WHERE id_member = %s"
+
+    SQL_GET_ALL_GROUPS = r"SELECT id_group, group_name FROM smf_membergroups"
+
+    SQL_GET_USER_GROUPS = r"SELECT additional_groups FROM smf_members WHERE id_member = %s"
+
+    SQL_ADD_USER_AVATAR = r"UPDATE smf_members SET avatar = %s WHERE id_member = %s"
+
+    @staticmethod
+    def _sanitize_groupname(name):
+        name = name.strip(' _')
+        return re.sub('[^\w.-]', '', name)
+
+    @staticmethod
+    def generate_random_pass():
+        return ''.join([random.choice(string.ascii_letters + string.digits) for n in range(16)])
+
+    @staticmethod
+    def gen_hash(username_clean, passwd):
+        return hashlib.sha1((username_clean + passwd).encode('utf-8')).hexdigest()
+
+    @staticmethod
+    def santatize_username(username):
+        sanatized = username.replace(" ", "_")
+        sanatized = sanatized.replace("'", "_")
+        return sanatized.lower()
+
+    @staticmethod
+    def get_current_utc_date():
+        d = datetime.utcnow()
+        unixtime = calendar.timegm(d.utctimetuple())
+        return unixtime
+
+    @classmethod
+    def create_group(cls, groupname):
+        logger.debug("Creating smf group %s" % groupname)
+        cursor = connections['smf'].cursor()
+        cursor.execute(cls.SQL_ADD_GROUP, [groupname, groupname])
+        logger.info("Created smf group %s" % groupname)
+        return cls.get_group_id(groupname)
+
+    @classmethod
+    def get_group_id(cls, groupname):
+        logger.debug("Getting smf group id for groupname %s" % groupname)
+        cursor = connections['smf'].cursor()
+        cursor.execute(cls.SQL_GET_GROUP_ID, [groupname])
+        row = cursor.fetchone()
+        logger.debug("Got smf group id %s for groupname %s" % (row[0], groupname))
+        return row[0]
+
+    @classmethod
+    def check_user(cls, username):
+        logger.debug("Checking smf username %s" % username)
+        cursor = connections['smf'].cursor()
+        cursor.execute(cls.SQL_USER_ID_FROM_USERNAME, [cls.santatize_username(username)])
+        row = cursor.fetchone()
+        if row:
+            logger.debug("Found user %s on smf" % username)
+            return True
+        logger.debug("User %s not found on smf" % username)
+        return False
+
+    @classmethod
+    def add_avatar(cls, member_name, characterid):
+        logger.debug("Adding EVE character id %s portrait as smf avatar for user %s" % (characterid, member_name))
+        avatar_url = "https://image.eveonline.com/Character/" + characterid + "_64.jpg"
+        cursor = connections['smf'].cursor()
+        id_member = cls.get_user_id(member_name)
+        cursor.execute(cls.SQL_ADD_USER_AVATAR, [avatar_url, id_member])
+
+    @classmethod
+    def get_user_id(cls, username):
+        logger.debug("Getting smf user id for username %s" % username)
+        cursor = connections['smf'].cursor()
+        cursor.execute(cls.SQL_USER_ID_FROM_USERNAME, [username])
+        row = cursor.fetchone()
+        if row is not None:
+            logger.debug("Got smf user id %s for username %s" % (row[0], username))
+            return row[0]
+        else:
+            logger.error("username %s not found on smf. Unable to determine user id ." % username)
+            return None
+
+    @classmethod
+    def get_all_groups(cls):
+        logger.debug("Getting all smf groups.")
+        cursor = connections['smf'].cursor()
+        cursor.execute(cls.SQL_GET_ALL_GROUPS)
+        rows = cursor.fetchall()
+        out = {}
+        for row in rows:
+            out[row[1]] = row[0]
+        logger.debug("Got smf groups %s" % out)
+        return out
+
+    @classmethod
+    def get_user_groups(cls, userid):
+        logger.debug("Getting smf user id %s groups" % userid)
+        cursor = connections['smf'].cursor()
+        cursor.execute(cls.SQL_GET_USER_GROUPS, [userid])
+        out = [row[0] for row in cursor.fetchall()]
+        logger.debug("Got user %s smf groups %s" % (userid, out))
+        return out
+
+    @classmethod
+    def add_user(cls, username, email_address, groups, characterid):
+        logger.debug("Adding smf user with member_name %s, email_address %s, characterid %s" % (
+            username, email_address, characterid))
+        cursor = connections['smf'].cursor()
+        username_clean = cls.santatize_username(username)
+        passwd = cls.generate_random_pass()
+        pwhash = cls.gen_hash(username_clean, passwd)
+        logger.debug("Proceeding to add smf user %s and pwhash starting with %s" % (username, pwhash[0:5]))
+        register_date = cls.get_current_utc_date()
+        # check if the username was simply revoked
+        if cls.check_user(username) is True:
+            logger.warn("Unable to add smf user with username %s - already exists. Updating user instead." % username)
+            cls.__update_user_info(username_clean, email_address, pwhash)
+        else:
+            try:
+                cursor.execute(cls.SQL_ADD_USER,
+                               [username_clean, passwd, email_address, register_date, username_clean])
+                cls.add_avatar(username_clean, characterid)
+                logger.info("Added smf member_name %s" % username_clean)
+                cls.update_groups(username_clean, groups)
+            except:
+                logger.warn("Unable to add smf user %s" % username_clean)
+                pass
+        return username_clean, passwd
+
+    @classmethod
+    def __update_user_info(cls, username, email_address, passwd):
+        logger.debug(
+            "Updating smf user %s info: username %s password of length %s" % (username, email_address, len(passwd)))
+        cursor = connections['smf'].cursor()
+        try:
+            cursor.execute(cls.SQL_DIS_USER, [email_address, passwd, username])
+            logger.info("Updated smf user %s info" % username)
+        except:
+            logger.exception("Unable to update smf user %s info." % username)
+            pass
+
+    @classmethod
+    def delete_user(cls, username):
+        logger.debug("Deleting smf user %s" % username)
+        cursor = connections['smf'].cursor()
+
+        if cls.check_user(username):
+            cursor.execute(cls.SQL_DEL_USER, [username])
+            logger.info("Deleted smf user %s" % username)
+            return True
+        logger.error("Unable to delete smf user %s - user not found on smf." % username)
+        return False
+
+    @classmethod
+    def update_groups(cls, username, groups):
+        userid = cls.get_user_id(username)
+        logger.debug("Updating smf user %s with id %s groups %s" % (username, userid, groups))
+        if userid is not None:
+            forum_groups = cls.get_all_groups()
+            user_groups = set(cls.get_user_groups(userid))
+            act_groups = set([cls._sanitize_groupname(g) for g in groups])
+            addgroups = act_groups - user_groups
+            remgroups = user_groups - act_groups
+            logger.info("Updating smf user %s groups - adding %s, removing %s" % (username, addgroups, remgroups))
+            act_group_id = set()
+            for g in addgroups:
+                if g not in forum_groups:
+                    forum_groups[g] = cls.create_group(g)
+                act_group_id.add(str(cls.get_group_id(g)))
+            string_groups = ','.join(act_group_id)
+            cls.add_user_to_group(userid, string_groups)
+
+    @classmethod
+    def add_user_to_group(cls, userid, groupid):
+        logger.debug("Adding smf user id %s to group id %s" % (userid, groupid))
+        try:
+            cursor = connections['smf'].cursor()
+            cursor.execute(cls.SQL_ADD_USER_GROUP, [groupid, userid])
+            logger.info("Added smf user id %s to group id %s" % (userid, groupid))
+        except:
+            logger.exception("Unable to add smf user id %s to group id %s" % (userid, groupid))
+            pass
+
+    @classmethod
+    def remove_user_from_group(cls, userid, groupid):
+        logger.debug("Removing smf user id %s from group id %s" % (userid, groupid))
+        try:
+            cursor = connections['smf'].cursor()
+            cursor.execute(cls.SQL_REMOVE_USER_GROUP, [groupid, userid])
+            logger.info("Removed smf user id %s from group id %s" % (userid, groupid))
+        except:
+            logger.exception("Unable to remove smf user id %s from group id %s" % (userid, groupid))
+            pass
+
+    @classmethod
+    def disable_user(cls, username):
+        logger.debug("Disabling smf user %s" % username)
+        cursor = connections['smf'].cursor()
+
+        password = cls.generate_random_pass()
+        revoke_email = "revoked@" + settings.DOMAIN
+        try:
+            pwhash = cls.gen_hash(username, password)
+            cursor.execute(cls.SQL_DIS_USER, [revoke_email, pwhash, username])
+            cls.get_user_id(username)
+            cls.update_groups(username, [])
+            logger.info("Disabled smf user %s" % username)
+            return True
+        except TypeError:
+            logger.exception("TypeError occured while disabling user %s - failed to disable." % username)
+            return False
+
+    @classmethod
+    def update_user_password(cls, username, characterid, password=None):
+        logger.debug("Updating smf user %s password" % username)
+        cursor = connections['smf'].cursor()
+        if not password:
+            password = cls.generate_random_pass()
+        if cls.check_user(username):
+            username_clean = cls.santatize_username(username)
+            pwhash = cls.gen_hash(username_clean, password)
+            logger.debug(
+                "Proceeding to update smf user %s password with pwhash starting with %s" % (username, pwhash[0:5]))
+            cursor.execute(cls.SQL_UPDATE_USER_PASSWORD, [pwhash, username])
+            cls.add_avatar(username, characterid)
+            logger.info("Updated smf user %s password." % username)
+            return password
+        logger.error("Unable to update smf user %s password - user not found on smf." % username)
+        return ""

services/modules/smf/migrations/0001_initial.py

@@ -0,0 +1,26 @@
+# -*- coding: utf-8 -*-
+# Generated by Django 1.10.2 on 2016-12-12 03:28
+from __future__ import unicode_literals
+
+from django.conf import settings
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+
+    initial = True
+
+    dependencies = [
+        ('auth', '0008_alter_user_username_max_length'),
+    ]
+
+    operations = [
+        migrations.CreateModel(
+            name='SmfUser',
+            fields=[
+                ('user', models.OneToOneField(on_delete=django.db.models.deletion.CASCADE, primary_key=True, related_name='smf', serialize=False, to=settings.AUTH_USER_MODEL)),
+                ('username', models.CharField(max_length=254)),
+            ],
+        ),
+    ]

services/modules/smf/models.py

@@ -0,0 +1,15 @@
+from __future__ import unicode_literals
+from django.utils.encoding import python_2_unicode_compatible
+from django.db import models
+
+
+@python_2_unicode_compatible
+class SmfUser(models.Model):
+    user = models.OneToOneField('auth.User',
+                                primary_key=True,
+                                on_delete=models.CASCADE,
+                                related_name='smf')
+    username = models.CharField(max_length=254)
+
+    def __str__(self):
+        return self.username

services/modules/smf/tasks.py

@@ -0,0 +1,75 @@
+from __future__ import unicode_literals
+
+import logging
+
+from alliance_auth.celeryapp import app
+from django.conf import settings
+from django.contrib.auth.models import User
+from django.core.exceptions import ObjectDoesNotExist
+from notifications import notify
+
+from .manager import SmfManager
+from .models import SmfUser
+
+logger = logging.getLogger(__name__)
+
+
+class SmfTasks:
+    def __init__(self):
+        pass
+
+    @classmethod
+    def delete_user(cls, user, notify_user=False):
+        if cls.has_account(user):
+            logger.debug("User %s has a SMF account %s. Deleting." % (user, user.smf.username))
+            SmfManager.disable_user(user.smf.username)
+            user.smf.delete()
+            if notify_user:
+                notify(user, "SMF Account Disabled", level='danger')
+            return True
+        return False
+
+    @staticmethod
+    def has_account(user):
+        try:
+            return user.smf.username != ''
+        except ObjectDoesNotExist:
+            return False
+
+    @classmethod
+    def disable(cls):
+        if settings.ENABLE_AUTH_SMF:
+            logger.warn(
+                "ENABLE_AUTH_SMF still True, after disabling users will still be able to link smf accounts")
+        if settings.ENABLE_BLUE_SMF:
+            logger.warn(
+                "ENABLE_BLUE_SMF still True, after disabling blues will still be able to link smf accounts")
+        SmfUser.objects.all().delete()
+
+    @staticmethod
+    @app.task(bind=True)
+    def update_groups(self, pk):
+        user = User.objects.get(pk=pk)
+        logger.debug("Updating smf groups for user %s" % user)
+        if SmfTasks.has_account(user):
+            groups = []
+            for group in user.groups.all():
+                groups.append(str(group.name))
+            if len(groups) == 0:
+                groups.append('empty')
+            logger.debug("Updating user %s smf groups to %s" % (user, groups))
+            try:
+                SmfManager.update_groups(user.smf.username, groups)
+            except:
+                logger.exception("smf group sync failed for %s, retrying in 10 mins" % user)
+                raise self.retry(countdown=60 * 10)
+            logger.debug("Updated user %s smf groups." % user)
+        else:
+            logger.debug("User does not have an smf account")
+
+    @staticmethod
+    @app.task
+    def update_all_groups():
+        logger.debug("Updating ALL smf groups")
+        for user in SmfUser.objects.exclude(username__exact=''):
+            SmfTasks.update_groups.delay(user.user_id)

services/modules/smf/tests.py

@@ -0,0 +1,212 @@
+from __future__ import unicode_literals
+
+try:
+    # Py3
+    from unittest import mock
+except ImportError:
+    # Py2
+    import mock
+
+from django.test import TestCase, RequestFactory
+from django.conf import settings
+from django import urls
+from django.contrib.auth.models import User
+from django.core.exceptions import ObjectDoesNotExist
+
+from alliance_auth.tests.auth_utils import AuthUtils
+
+from .auth_hooks import SmfService
+from .models import SmfUser
+from .tasks import SmfTasks
+
+MODULE_PATH = 'services.modules.smf'
+
+
+class SmfHooksTestCase(TestCase):
+    def setUp(self):
+        self.member = 'member_user'
+        member = AuthUtils.create_member(self.member)
+        SmfUser.objects.create(user=member, username=self.member)
+        self.blue = 'blue_user'
+        blue = AuthUtils.create_blue(self.blue)
+        SmfUser.objects.create(user=blue, username=self.blue)
+        self.none_user = 'none_user'
+        none_user = AuthUtils.create_user(self.none_user)
+        self.service = SmfService
+
+    def test_has_account(self):
+        member = User.objects.get(username=self.member)
+        blue = User.objects.get(username=self.blue)
+        none_user = User.objects.get(username=self.none_user)
+        self.assertTrue(SmfTasks.has_account(member))
+        self.assertTrue(SmfTasks.has_account(blue))
+        self.assertFalse(SmfTasks.has_account(none_user))
+
+    def test_service_enabled(self):
+        service = self.service()
+        member = User.objects.get(username=self.member)
+        blue = User.objects.get(username=self.blue)
+        none_user = User.objects.get(username=self.none_user)
+        self.assertTrue(service.service_enabled_members())
+        self.assertTrue(service.service_enabled_blues())
+
+        self.assertEqual(service.service_active_for_user(member), settings.ENABLE_AUTH_SMF)
+        self.assertEqual(service.service_active_for_user(blue), settings.ENABLE_BLUE_SMF)
+        self.assertFalse(service.service_active_for_user(none_user))
+
+    @mock.patch(MODULE_PATH + '.tasks.SmfManager')
+    def test_update_all_groups(self, manager):
+        service = self.service()
+        service.update_all_groups()
+        # Check member and blue user have groups updated
+        self.assertTrue(manager.update_groups.called)
+        self.assertEqual(manager.update_groups.call_count, 2)
+
+    def test_update_groups(self):
+        # Check member has Member group updated
+        with mock.patch(MODULE_PATH + '.tasks.SmfManager') as manager:
+            service = self.service()
+            member = User.objects.get(username=self.member)
+            service.update_groups(member)
+            self.assertTrue(manager.update_groups.called)
+            args, kwargs = manager.update_groups.call_args
+            user_id, groups = args
+            self.assertIn(settings.DEFAULT_AUTH_GROUP, groups)
+            self.assertEqual(user_id, member.smf.username)
+
+        # Check none user does not have groups updated
+        with mock.patch(MODULE_PATH + '.tasks.SmfManager') as manager:
+            service = self.service()
+            none_user = User.objects.get(username=self.none_user)
+            service.update_groups(none_user)
+            self.assertFalse(manager.update_groups.called)
+
+    @mock.patch(MODULE_PATH + '.tasks.SmfManager')
+    def test_validate_user(self, manager):
+        service = self.service()
+        # Test member is not deleted
+        member = User.objects.get(username=self.member)
+        service.validate_user(member)
+        self.assertTrue(member.smf)
+
+        # Test none user is deleted
+        none_user = User.objects.get(username=self.none_user)
+        SmfUser.objects.create(user=none_user, username='abc123')
+        service.validate_user(none_user)
+        self.assertTrue(manager.disable_user.called)
+        with self.assertRaises(ObjectDoesNotExist):
+            none_smf = User.objects.get(username=self.none_user).smf
+
+    @mock.patch(MODULE_PATH + '.tasks.SmfManager')
+    def test_delete_user(self, manager):
+        member = User.objects.get(username=self.member)
+
+        service = self.service()
+        result = service.delete_user(member)
+
+        self.assertTrue(result)
+        self.assertTrue(manager.disable_user.called)
+        with self.assertRaises(ObjectDoesNotExist):
+            smf_user = User.objects.get(username=self.member).smf
+
+    def test_render_services_ctrl(self):
+        service = self.service()
+        member = User.objects.get(username=self.member)
+        request = RequestFactory().get('/en/services/')
+        request.user = member
+
+        response = service.render_services_ctrl(request)
+        self.assertTemplateUsed(service.service_ctrl_template)
+        self.assertIn(urls.reverse('auth_deactivate_smf'), response)
+        self.assertIn(urls.reverse('auth_reset_smf_password'), response)
+        self.assertIn(urls.reverse('auth_set_smf_password'), response)
+
+        # Test register becomes available
+        member.smf.delete()
+        member = User.objects.get(username=self.member)
+        request.user = member
+        response = service.render_services_ctrl(request)
+        self.assertIn(urls.reverse('auth_activate_smf'), response)
+
+
+class SmfViewsTestCase(TestCase):
+    def setUp(self):
+        self.member = AuthUtils.create_member('auth_member')
+        self.member.set_password('password')
+        self.member.email = 'auth_member@example.com'
+        self.member.save()
+        AuthUtils.add_main_character(self.member, 'auth_member', '12345', corp_id='111', corp_name='Test Corporation')
+
+    def login(self):
+        self.client.login(username=self.member.username, password='password')
+
+    @mock.patch(MODULE_PATH + '.tasks.SmfManager')
+    @mock.patch(MODULE_PATH + '.views.SmfManager')
+    def test_activate(self, manager, tasks_manager):
+        self.login()
+        expected_username = 'auth_member'
+        manager.add_user.return_value = (expected_username, 'abc123')
+
+        response = self.client.get(urls.reverse('auth_activate_smf'))
+
+        self.assertTrue(manager.add_user.called)
+        self.assertTrue(tasks_manager.update_groups.called)
+        self.assertEqual(response.status_code, 200)
+        self.assertTemplateUsed('registered/service_credentials.html')
+        self.assertContains(response, expected_username)
+        smf_user = SmfUser.objects.get(user=self.member)
+        self.assertEqual(smf_user.username, expected_username)
+
+    @mock.patch(MODULE_PATH + '.tasks.SmfManager')
+    def test_deactivate(self, manager):
+        self.login()
+        SmfUser.objects.create(user=self.member, username='some member')
+
+        response = self.client.get(urls.reverse('auth_deactivate_smf'))
+
+        self.assertTrue(manager.disable_user.called)
+        self.assertRedirects(response, expected_url=urls.reverse('auth_services'), target_status_code=200)
+        with self.assertRaises(ObjectDoesNotExist):
+            smf_user = User.objects.get(pk=self.member.pk).smf
+
+    @mock.patch(MODULE_PATH + '.views.SmfManager')
+    def test_set_password(self, manager):
+        self.login()
+        SmfUser.objects.create(user=self.member, username='some member')
+
+        response = self.client.post(urls.reverse('auth_set_smf_password'), data={'password': '1234asdf'})
+
+        self.assertTrue(manager.update_user_password.called)
+        args, kwargs = manager.update_user_password.call_args
+        self.assertEqual(kwargs['password'], '1234asdf')
+        self.assertRedirects(response, expected_url=urls.reverse('auth_services'), target_status_code=200)
+
+    @mock.patch(MODULE_PATH + '.views.SmfManager')
+    def test_reset_password(self, manager):
+        self.login()
+        SmfUser.objects.create(user=self.member, username='some member')
+
+        manager.update_user_password.return_value = 'hunter2'
+
+        response = self.client.get(urls.reverse('auth_reset_smf_password'))
+
+        self.assertTemplateUsed(response, 'registered/service_credentials.html')
+        self.assertContains(response, 'some member')
+        self.assertContains(response, 'hunter2')
+
+
+class SmfManagerTestCase(TestCase):
+    def setUp(self):
+        from .manager import SmfManager
+        self.manager = SmfManager
+
+    def test_generate_random_password(self):
+        password = self.manager.generate_random_pass()
+
+        self.assertEqual(len(password), 16)
+        self.assertIsInstance(password, type(''))
+
+    def test_gen_hash(self):
+        pwhash = self.manager.gen_hash('username', 'test')
+
+        self.assertEqual(pwhash, 'b6d21d37de84db76746b1c45696a00f9ce4f86fd')

services/modules/smf/urls.py

@@ -0,0 +1,16 @@
+from __future__ import unicode_literals
+from django.conf.urls import url, include
+
+from . import views
+
+module_urls = [
+    # SMF Service Control
+    url(r'^activate/$', views.activate_smf, name='auth_activate_smf'),
+    url(r'^deactivate/$', views.deactivate_smf, name='auth_deactivate_smf'),
+    url(r'^reset_password/$', views.reset_smf_password, name='auth_reset_smf_password'),
+    url(r'^set_password/$', views.set_smf_password, name='auth_set_smf_password'),
+]
+
+urlpatterns = [
+    url(r'^smf/', include(module_urls)),
+]

services/modules/smf/views.py

@@ -0,0 +1,111 @@
+from __future__ import unicode_literals
+
+from django.contrib import messages
+from django.contrib.auth.decorators import login_required
+from django.shortcuts import render, redirect
+
+from authentication.decorators import members_and_blues
+from eveonline.managers import EveManager
+from services.forms import ServicePasswordForm
+
+from .manager import SmfManager
+from .tasks import SmfTasks
+from .models import SmfUser
+
+import logging
+
+logger = logging.getLogger(__name__)
+
+
+@login_required
+@members_and_blues()
+def activate_smf(request):
+    logger.debug("activate_smf called by user %s" % request.user)
+    # Valid now we get the main characters
+    character = EveManager.get_main_character(request.user)
+    logger.debug("Adding smf user for user %s with main character %s" % (request.user, character))
+    result = SmfManager.add_user(character.character_name, request.user.email, ['Member'], character.character_id)
+    # if empty we failed
+    if result[0] != "":
+        SmfUser.objects.update_or_create(user=request.user, defaults={'username': result[0]})
+        logger.debug("Updated authserviceinfo for user %s with smf credentials. Updating groups." % request.user)
+        SmfTasks.update_groups.delay(request.user.pk)
+        logger.info("Successfully activated smf for user %s" % request.user)
+        messages.success(request, 'Activated SMF account.')
+        credentials = {
+            'username': result[0],
+            'password': result[1],
+        }
+        return render(request, 'registered/service_credentials.html',
+                      context={'credentials': credentials, 'service': 'SMF'})
+    else:
+        logger.error("Unsuccessful attempt to activate smf for user %s" % request.user)
+        messages.error(request, 'An error occurred while processing your SMF account.')
+    return redirect("auth_services")
+
+
+@login_required
+@members_and_blues()
+def deactivate_smf(request):
+    logger.debug("deactivate_smf called by user %s" % request.user)
+    result = SmfTasks.delete_user(request.user)
+    # false we failed
+    if result:
+        logger.info("Successfully deactivated smf for user %s" % request.user)
+        messages.success(request, 'Deactivated SMF account.')
+    else:
+        logger.error("Unsuccessful attempt to activate smf for user %s" % request.user)
+        messages.error(request, 'An error occurred while processing your SMF account.')
+    return redirect("auth_services")
+
+
+@login_required
+@members_and_blues()
+def reset_smf_password(request):
+    logger.debug("reset_smf_password called by user %s" % request.user)
+    character = EveManager.get_main_character(request.user)
+    if SmfTasks.has_account(request.user) and character is not None:
+        result = SmfManager.update_user_password(request.user.smf.username, character.character_id)
+        # false we failed
+        if result != "":
+            logger.info("Successfully reset smf password for user %s" % request.user)
+            messages.success(request, 'Reset SMF password.')
+            credentials = {
+                'username': request.user.smf.username,
+                'password': result,
+            }
+            return render(request, 'registered/service_credentials.html',
+                          context={'credentials': credentials, 'service': 'SMF'})
+    logger.error("Unsuccessful attempt to reset smf password for user %s" % request.user)
+    messages.error(request, 'An error occurred while processing your SMF account.')
+    return redirect("auth_services")
+
+
+@login_required
+@members_and_blues()
+def set_smf_password(request):
+    logger.debug("set_smf_password called by user %s" % request.user)
+    if request.method == 'POST':
+        logger.debug("Received POST request with form.")
+        form = ServicePasswordForm(request.POST)
+        logger.debug("Form is valid: %s" % form.is_valid())
+        character = EveManager.get_main_character(request.user)
+        if form.is_valid() and SmfTasks.has_account(request.user) and character is not None:
+            password = form.cleaned_data['password']
+            logger.debug("Form contains password of length %s" % len(password))
+            result = SmfManager.update_user_password(request.user.smf.username, character.character_id,
+                                                     password=password)
+            if result != "":
+                logger.info("Successfully set smf password for user %s" % request.user)
+                messages.success(request, 'Set SMF password.')
+            else:
+                logger.error("Failed to install custom smf password for user %s" % request.user)
+                messages.error(request, 'An error occurred while processing your SMF account.')
+            return redirect("auth_services")
+    else:
+        logger.debug("Request is not type POST - providing empty form.")
+        form = ServicePasswordForm()
+
+    logger.debug("Rendering form for user %s" % request.user)
+    context = {'form': form, 'service': 'SMF'}
+    return render(request, 'registered/service_password.html', context=context)