From 13204a7e91af606bd739d79aafc54e3cc2016521 Mon Sep 17 00:00:00 2001 From: Basraah Date: Sun, 29 Jan 2017 10:46:51 +1000 Subject: [PATCH] Fixed incorrect parameters for task apply call (#680) Added test to ensure member groups are correctly applied after `activate_mumble` is called. --- services/modules/mumble/tests.py | 1 + services/modules/mumble/views.py | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/services/modules/mumble/tests.py b/services/modules/mumble/tests.py index b65569c0..6b6e7db9 100644 --- a/services/modules/mumble/tests.py +++ b/services/modules/mumble/tests.py @@ -147,6 +147,7 @@ class MumbleViewsTestCase(TestCase): self.assertEqual(mumble_user.username, expected_username) self.assertTrue(mumble_user.pwhash) self.assertEqual(self.member.mumble.username, expected_username) + self.assertEqual('Member', mumble_user.groups) def test_deactivate(self): self.login() diff --git a/services/modules/mumble/views.py b/services/modules/mumble/views.py index 866ab9a2..b3a76c5a 100644 --- a/services/modules/mumble/views.py +++ b/services/modules/mumble/views.py @@ -41,7 +41,7 @@ def activate_mumble(request): if result: logger.debug("Updated authserviceinfo for user %s with mumble credentials. Updating groups." % request.user) - MumbleTasks.update_groups.apply(request.user.pk) # Run synchronously to prevent timing issues + MumbleTasks.update_groups.apply(args=(request.user.pk,)) # Run synchronously to prevent timing issues logger.info("Successfully activated mumble for user %s" % request.user) messages.success(request, 'Activated Mumble account.') credentials = {