From 1420c71ec50095f0222a05673add6dfd74a1dfe1 Mon Sep 17 00:00:00 2001 From: ErikKalkoken Date: Sat, 15 May 2021 13:58:23 +0200 Subject: [PATCH] Improve get_character_by_id() --- allianceauth/eveonline/managers.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/allianceauth/eveonline/managers.py b/allianceauth/eveonline/managers.py index ea574189..19337886 100644 --- a/allianceauth/eveonline/managers.py +++ b/allianceauth/eveonline/managers.py @@ -32,10 +32,12 @@ class EveCharacterManager(models.Manager): def update_character(self, character_id): return self.get(character_id=character_id).update_character() - def get_character_by_id(self, char_id): - if self.filter(character_id=char_id).exists(): - return self.get(character_id=char_id) - return None + def get_character_by_id(self, character_id: int): + """Return character by character ID or None if not found.""" + try: + return self.get(character_id=character_id) + except self.model.DoesNotExist: + return None class EveAllianceProviderManager: