diff --git a/allianceauth/groupmanagement/managers.py b/allianceauth/groupmanagement/managers.py index bdb6dc9d..de5f2497 100644 --- a/allianceauth/groupmanagement/managers.py +++ b/allianceauth/groupmanagement/managers.py @@ -23,6 +23,15 @@ class GroupManager: """ return not group.authgroup.internal + @staticmethod + def auditable_group(group): + """ + Check if a group is auditable, i.e not an internal group + :param group: django.contrib.auth.models.Group object + :return: bool True if it is auditable, false otherwise + """ + return not group.authgroup.internal + @staticmethod def has_management_permission(user): return user.has_perm('auth.group_management') diff --git a/allianceauth/groupmanagement/views.py b/allianceauth/groupmanagement/views.py index 2ee8438a..0baf2085 100755 --- a/allianceauth/groupmanagement/views.py +++ b/allianceauth/groupmanagement/views.py @@ -74,7 +74,7 @@ def group_membership_audit(request, group_id): # Check its a joinable group i.e. not corp or internal # And the user has permission to manage it - if not GroupManager.joinable_group(group) or not GroupManager.can_manage_group(request.user, group): + if not GroupManager.auditable_group(group) or not GroupManager.can_manage_group(request.user, group): logger.warning("User %s attempted to view the membership of group %s but permission was denied" % (request.user, group_id)) raise PermissionDenied