From 5b8983deacafa0e16e44c39779c88749e5598a50 Mon Sep 17 00:00:00 2001 From: colcrunch Date: Sun, 22 Jul 2018 20:08:16 -0400 Subject: [PATCH] Rename Auditable group. Its better to be explicit. --- allianceauth/groupmanagement/managers.py | 2 +- allianceauth/groupmanagement/views.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/allianceauth/groupmanagement/managers.py b/allianceauth/groupmanagement/managers.py index de5f2497..0a6ebe24 100644 --- a/allianceauth/groupmanagement/managers.py +++ b/allianceauth/groupmanagement/managers.py @@ -24,7 +24,7 @@ class GroupManager: return not group.authgroup.internal @staticmethod - def auditable_group(group): + def check_internal_group(group): """ Check if a group is auditable, i.e not an internal group :param group: django.contrib.auth.models.Group object diff --git a/allianceauth/groupmanagement/views.py b/allianceauth/groupmanagement/views.py index 0baf2085..39014f20 100755 --- a/allianceauth/groupmanagement/views.py +++ b/allianceauth/groupmanagement/views.py @@ -74,7 +74,7 @@ def group_membership_audit(request, group_id): # Check its a joinable group i.e. not corp or internal # And the user has permission to manage it - if not GroupManager.auditable_group(group) or not GroupManager.can_manage_group(request.user, group): + if not GroupManager.check_internal_group(group) or not GroupManager.can_manage_group(request.user, group): logger.warning("User %s attempted to view the membership of group %s but permission was denied" % (request.user, group_id)) raise PermissionDenied