From 5d9a3b6b439e520e7d5eec09464a1cd5f3e48697 Mon Sep 17 00:00:00 2001 From: Adarnof Date: Wed, 23 Dec 2015 01:26:30 +0000 Subject: [PATCH] Removed unused exception handling from group update --- services/managers/openfire_manager.py | 39 +++++++++++++-------------- 1 file changed, 18 insertions(+), 21 deletions(-) diff --git a/services/managers/openfire_manager.py b/services/managers/openfire_manager.py index dae56432..aea8bdf2 100755 --- a/services/managers/openfire_manager.py +++ b/services/managers/openfire_manager.py @@ -81,27 +81,24 @@ class OpenfireManager: @staticmethod def update_user_groups(username, password, groups): - try: - api = ofUsers(settings.OPENFIRE_ADDRESS, settings.OPENFIRE_SECRET_KEY) - response = api.get_user_groups(username) - remote_groups = [] - if response: - remote_groups = response['groupname'] - add_groups = [] - del_groups = [] - for g in groups: - if not g in remote_groups: - add_groups.append(g) - for g in remote_groups: - if not g in groups: - del_groups.append(g) - if add_groups: - api.add_user_groups(username, add_groups) - if del_groups: - api.delete_user_groups(username, del_groups) - except e: - print e - + api = ofUsers(settings.OPENFIRE_ADDRESS, settings.OPENFIRE_SECRET_KEY) + response = api.get_user_groups(username) + remote_groups = [] + if response: + remote_groups = response['groupname'] + add_groups = [] + del_groups = [] + for g in groups: + if not g in remote_groups: + add_groups.append(g) + for g in remote_groups: + if not g in groups: + del_groups.append(g) + if add_groups: + api.add_user_groups(username, add_groups) + if del_groups: + api.delete_user_groups(username, del_groups) + @staticmethod def delete_user_groups(username, groups):