From 9ea79ea3896e7e60b17957c2b38aeea896e5eabd Mon Sep 17 00:00:00 2001
From: ErikKalkoken <erik.kalkoken@gmail.com>
Date: Thu, 26 Mar 2020 00:10:30 +0100
Subject: [PATCH] Move docu link to top menu and open in new window

---
 allianceauth/authentication/urls.py            |  9 +--------
 allianceauth/templates/allianceauth/help.html  | 18 ------------------
 .../templates/allianceauth/side-menu.html      | 10 +---------
 .../templates/allianceauth/top-menu.html       |  7 +++++++
 4 files changed, 9 insertions(+), 35 deletions(-)
 delete mode 100644 allianceauth/templates/allianceauth/help.html

diff --git a/allianceauth/authentication/urls.py b/allianceauth/authentication/urls.py
index 962483fe..11fee0b9 100644
--- a/allianceauth/authentication/urls.py
+++ b/allianceauth/authentication/urls.py
@@ -22,13 +22,6 @@ urlpatterns = [
         r'^account/characters/add/$', 
         views.add_character, 
         name='add_character'
-    ),
-    url(
-        r'^help/$', 
-        login_required(
-            TemplateView.as_view(template_name='allianceauth/help.html')
-        ),
-        name='help'
-    ),
+    ),   
     url(r'^dashboard/$', views.dashboard, name='dashboard'),
 ]
diff --git a/allianceauth/templates/allianceauth/help.html b/allianceauth/templates/allianceauth/help.html
deleted file mode 100644
index 4056dd0d..00000000
--- a/allianceauth/templates/allianceauth/help.html
+++ /dev/null
@@ -1,18 +0,0 @@
-{% extends "allianceauth/base.html" %}
-{% load i18n %}
-
-{% block page_title %}{% trans "Help" %}{% endblock page_title %}
-
-{% block content %}
-    <div class="col-lg-12">
-
-        <h1 class="page-header text-center">{%  trans "Help" %}</h1>
-
-        <div class="container-fluid">
-            <div class="embed-responsive embed-responsive-16by9">
-                <iframe class="embed-responsive-item" src="https://allianceauth.readthedocs.io/en/latest/features/"></iframe>
-            </div>
-        </div>
-    </div>
-{% endblock content %}
-
diff --git a/allianceauth/templates/allianceauth/side-menu.html b/allianceauth/templates/allianceauth/side-menu.html
index 65270d33..bef3d097 100644
--- a/allianceauth/templates/allianceauth/side-menu.html
+++ b/allianceauth/templates/allianceauth/side-menu.html
@@ -26,15 +26,7 @@
             {% endif %}
 
             {% menu_items %}
-
-            {% if user.is_superuser %}
-                <li>
-                    <a class="{% navactive request 'authentication:help' %}"
-                       href="{% url 'authentication:help' %}">
-                        <i class="fa fa-question fa-fw"></i> {% trans "Help" %}
-                    </a>
-                </li>
-            {% endif %}
+           
         </ul>
     </div>
 </div>
diff --git a/allianceauth/templates/allianceauth/top-menu.html b/allianceauth/templates/allianceauth/top-menu.html
index f88bc320..ab491d52 100644
--- a/allianceauth/templates/allianceauth/top-menu.html
+++ b/allianceauth/templates/allianceauth/top-menu.html
@@ -39,6 +39,13 @@
                 {% else %}
                     <li><a href="{% url 'authentication:login' %}">{% trans "Login" %}</a></li>
                 {% endif %}
+                {% if user.is_superuser %}
+                    <li>
+                        <a href="https://allianceauth.readthedocs.io/" target="_blank">
+                            <i class="fa fa-question-circle fa-fw"></i>
+                        </a>
+                    </li>
+                {% endif %}
             </ul>
             <form id="f-lang-select" class="navbar-form navbar-right" action="{% url 'set_language' %}" method="post">
                 {% csrf_token %}