Handle HTTP429 on nickname API endpoint

Closes #971
This commit is contained in:
Adarnof 2018-02-21 17:47:05 -05:00
parent 8ce8789631
commit a64dda2a2e
2 changed files with 8 additions and 3 deletions

View File

@ -210,6 +210,7 @@ class DiscordOAuthManager:
return None return None
@staticmethod @staticmethod
@api_backoff
def update_nickname(user_id, nickname): def update_nickname(user_id, nickname):
try: try:
nickname = DiscordOAuthManager._sanitize_name(nickname) nickname = DiscordOAuthManager._sanitize_name(nickname)

View File

@ -92,7 +92,7 @@ class DiscordTasks:
@staticmethod @staticmethod
@shared_task(bind=True, name='discord.update_nickname') @shared_task(bind=True, name='discord.update_nickname')
def update_nickname(self, pk): def update_nickname(task_self, pk):
user = User.objects.get(pk=pk) user = User.objects.get(pk=pk)
logger.debug("Updating discord nickname for user %s" % user) logger.debug("Updating discord nickname for user %s" % user)
if DiscordTasks.has_account(user): if DiscordTasks.has_account(user):
@ -101,10 +101,14 @@ class DiscordTasks:
logger.debug("Updating user %s discord nickname to %s" % (user, character.character_name)) logger.debug("Updating user %s discord nickname to %s" % (user, character.character_name))
try: try:
DiscordOAuthManager.update_nickname(user.discord.uid, DiscordTasks.get_nickname(user)) DiscordOAuthManager.update_nickname(user.discord.uid, DiscordTasks.get_nickname(user))
except DiscordApiBackoff as bo:
logger.info("Discord nickname update API back off for %s, "
"retrying in %s seconds" % (user, bo.retry_after_seconds))
raise task_self.retry(countdown=bo.retry_after_seconds)
except Exception as e: except Exception as e:
if self: if task_self:
logger.exception("Discord nickname sync failed for %s, retrying in 10 mins" % user) logger.exception("Discord nickname sync failed for %s, retrying in 10 mins" % user)
raise self.retry(countdown=60 * 10) raise task_self.retry(countdown=60 * 10)
else: else:
# Rethrow # Rethrow
raise e raise e