From aec055b542a234050925fc6cfa12a43d649d84bc Mon Sep 17 00:00:00 2001
From: Aaron Kable <aaronkable@gmail.com>
Date: Thu, 8 Jan 2026 15:48:34 +0800
Subject: [PATCH] Add more some tests

---
 .../framework/tests/test_datatables.py        | 75 +++++++++++--------
 1 file changed, 43 insertions(+), 32 deletions(-)

diff --git a/allianceauth/framework/tests/test_datatables.py b/allianceauth/framework/tests/test_datatables.py
index c86e299d..cf7dee4c 100644
--- a/allianceauth/framework/tests/test_datatables.py
+++ b/allianceauth/framework/tests/test_datatables.py
@@ -29,38 +29,38 @@ class TestDataTables(TestCase):
 
     def setUp(self):
         self.get_params = {
-            'draw': ['1'],
-            'columns[0][data]': ['0'],
-            'columns[0][name]': [''],
-            'columns[0][searchable]': ['false'],
-            'columns[0][orderable]': ['false'],
-            'columns[0][search][value]': [''],
-            'columns[0][search][regex]': ['false'],
-            'columns[1][data]': ['1'],
-            'columns[1][name]': [''],
-            'columns[1][searchable]': ['true'],
-            'columns[1][orderable]': ['true'],
-            'columns[1][search][value]': [''],
-            'columns[1][search][regex]': ['false'],
-            'columns[2][data]': ['2'],
-            'columns[2][name]': [''],
-            'columns[2][searchable]': ['true'],
-            'columns[2][orderable]': ['false'],
-            'columns[2][search][value]': [''],
-            'columns[2][search][regex]': ['false'],
-            'columns[3][data]': ['3'],
-            'columns[3][name]': [''],
-            'columns[3][searchable]': ['true'],
-            'columns[3][orderable]': ['true'],
-            'columns[3][search][value]': [''],
-            'columns[3][search][regex]': ['false'],
-            'order[0][column]': ['1'],
-            'order[0][dir]': ['asc'],
-            'start': ['0'],
-            'length': ['10'],
-            'search[value]': [''],
-            'search[regex]': ['false'],
-            '_': ['123456789']
+            'draw': '1',
+            'columns[0][data]': '0',
+            'columns[0][name]': '',
+            'columns[0][searchable]': 'false',
+            'columns[0][orderable]': 'false',
+            'columns[0][search][value]': '',
+            'columns[0][search][regex]': 'false',
+            'columns[1][data]': '1',
+            'columns[1][name]': '',
+            'columns[1][searchable]': 'true',
+            'columns[1][orderable]': 'true',
+            'columns[1][search][value]': '',
+            'columns[1][search][regex]': 'false',
+            'columns[2][data]': '2',
+            'columns[2][name]': '',
+            'columns[2][searchable]': 'true',
+            'columns[2][orderable]': 'false',
+            'columns[2][search][value]': '',
+            'columns[2][search][regex]': 'false',
+            'columns[3][data]': '3',
+            'columns[3][name]': '',
+            'columns[3][searchable]': 'true',
+            'columns[3][orderable]': 'true',
+            'columns[3][search][value]': '',
+            'columns[3][search][regex]': 'false',
+            'order[0][column]': '1',
+            'order[0][dir]': 'asc',
+            'start': '0',
+            'length': '10',
+            'search[value]': '',
+            'search[regex]': 'false',
+            '_': '123456789'
         }
 
 
@@ -109,6 +109,17 @@ class TestDataTables(TestCase):
         self.assertEqual(data[0][0], "1020")
         self.assertEqual(data[9][0], "1011")
 
+    def test_view_non_sortable_sort(self):
+        self.get_params["order[0][dir]"] = "desc"
+        self.get_params["order[0][column]"] = "0"
+        self.client.force_login(self.user)
+        request = self.factory.get('/fake-url/', data=self.get_params)
+        response = TestView()
+        response.setup(request)
+        data = json.loads(response.get(request).content)["data"]
+        self.assertEqual(data[0][0], "1001")
+        self.assertEqual(data[9][0], "1010")
+
     def test_view_20_rows(self):
         self.get_params["length"] = "20"
         self.client.force_login(self.user)