From b6d6c68e54c88b6e3155ebe81e19113500080679 Mon Sep 17 00:00:00 2001 From: Peter Pfeufer Date: Tue, 23 Nov 2021 02:31:18 +0100 Subject: [PATCH] Fix tests Thanks to @ErikKalkoken for helping here --- .../authentication/tests/test_templatetags.py | 24 +++++++++++++++---- 1 file changed, 20 insertions(+), 4 deletions(-) diff --git a/allianceauth/authentication/tests/test_templatetags.py b/allianceauth/authentication/tests/test_templatetags.py index 8b142e17..50361724 100644 --- a/allianceauth/authentication/tests/test_templatetags.py +++ b/allianceauth/authentication/tests/test_templatetags.py @@ -310,7 +310,23 @@ class TestFetchListFromGitlab(TestCase): self.assertEqual(requests_mocker.call_count, max_pages) @requests_mock.mock() - def test_can_handle_connection_timeout(self, requests_mocker): - requests_mocker.get(self.url, exc=requests.exceptions.ConnectTimeout) - with self.assertRaises(requests.exceptions.ConnectTimeout): - result = _fetch_list_from_gitlab(self.url) + @patch(MODULE_PATH + '.admin_status.logger') + def test_should_not_raise_any_exception_from_github_request_but_log_as_warning( + self, requests_mocker, mock_logger + ): + for my_exception in [ + requests.exceptions.ConnectionError, + requests.exceptions.HTTPError, + requests.exceptions.URLRequired, + requests.exceptions.TooManyRedirects, + requests.exceptions.ConnectTimeout, + requests.exceptions.Timeout, + + ]: + requests_mocker.get(self.url, exc=my_exception) + try: + result = _fetch_list_from_gitlab(self.url) + except Exception as ex: + self.fail(f"Unexpected exception raised: {ex}") + self.assertTrue(mock_logger.warning.called) + self.assertListEqual(result, [])