From 8d63801b00b5a09746aa832723927530cbca63e4 Mon Sep 17 00:00:00 2001 From: r0kym Date: Fri, 15 Nov 2024 15:12:03 +0100 Subject: [PATCH 1/2] Change logging imports and commands Now uses `get_extension_logger` as is recommanded by https://allianceauth.readthedocs.io/en/v4.4.2/development/custom/logging.html --- docs/development/tech_docu/celery.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/development/tech_docu/celery.md b/docs/development/tech_docu/celery.md index 537b7d3d..4d87fc09 100644 --- a/docs/development/tech_docu/celery.md +++ b/docs/development/tech_docu/celery.md @@ -40,10 +40,10 @@ Please use the following approach to ensure your tasks are working properly with Here is an example implementation of a task: ```python -import logging +from allianceauth.services.hooks import get_extension_logger from celery import shared_task -logger = logging.getLogger(__name__) +logger = get_extension_logger(__name__) @shared_task @@ -80,10 +80,10 @@ However, many long-running tasks consist of several smaller processes that need Example implementation for a celery chain: ```python -import logging +from allianceauth.services.hooks import get_extension_logger from celery import shared_task, chain -logger = logging.getLogger(__name__) +logger = get_extension_logger(__name__) @shared_task From 2125192f723ade864eba26047cd6e00f676671cb Mon Sep 17 00:00:00 2001 From: r0kym Date: Fri, 15 Nov 2024 15:13:25 +0100 Subject: [PATCH 2/2] Fix typo in the long-running tasks example --- docs/development/tech_docu/celery.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/development/tech_docu/celery.md b/docs/development/tech_docu/celery.md index 4d87fc09..f92a0cb1 100644 --- a/docs/development/tech_docu/celery.md +++ b/docs/development/tech_docu/celery.md @@ -96,7 +96,7 @@ def long_runner(): my_tasks = list() for _ in range(10): task_signature = example.si() - my_task.append(task_signature) + my_tasks.append(task_signature) chain(my_tasks).delay() ```