From d88cb57cf0a855e8ac581ae7b384c2827538703d Mon Sep 17 00:00:00 2001 From: Peter Pfeufer Date: Tue, 9 Sep 2025 11:05:30 +0200 Subject: [PATCH] [CHANGE] User-Agent to our proposed default format --- .../services/modules/discord/discord_client/client.py | 5 ++--- .../modules/discord/discord_client/tests/test_client.py | 5 ++--- allianceauth/srp/managers.py | 4 ++-- 3 files changed, 6 insertions(+), 8 deletions(-) diff --git a/allianceauth/services/modules/discord/discord_client/client.py b/allianceauth/services/modules/discord/discord_client/client.py index 2e56d53e..cae4a7f5 100644 --- a/allianceauth/services/modules/discord/discord_client/client.py +++ b/allianceauth/services/modules/discord/discord_client/client.py @@ -16,8 +16,7 @@ from redis import Redis from allianceauth.utils.cache import get_redis_client -from allianceauth import __title__ as AUTH_TITLE -from allianceauth import __url__, __version__ +from allianceauth import __title_useragent__, __url__, __version__ from .. import __title__ from ..utils import LoggerAddTag @@ -647,7 +646,7 @@ class DiscordClient: if self.is_rate_limited: self._ensure_rate_limed_not_exhausted(uid) headers = { - 'User-Agent': f'{AUTH_TITLE} ({__url__}, {__version__})', + 'User-Agent': f'{__title_useragent__}/{__version__} (+{__url__})', 'accept': 'application/json', 'X-RateLimit-Precision': 'millisecond', 'authorization': str(authorization) diff --git a/allianceauth/services/modules/discord/discord_client/tests/test_client.py b/allianceauth/services/modules/discord/discord_client/tests/test_client.py index 5c7a5bf4..e9f8a03c 100644 --- a/allianceauth/services/modules/discord/discord_client/tests/test_client.py +++ b/allianceauth/services/modules/discord/discord_client/tests/test_client.py @@ -7,8 +7,7 @@ import requests_mock from redis import Redis from requests.exceptions import HTTPError -from allianceauth import __title__ as AUTH_TITLE -from allianceauth import __url__, __version__ +from allianceauth import __title_useragent__, __url__, __version__ from allianceauth.utils.testing import NoSocketsTestCase from ...utils import set_logger_to_file @@ -46,7 +45,7 @@ API_BASE_URL = 'https://discord.com/api/' TEST_RETRY_AFTER = 3000 DEFAULT_REQUEST_HEADERS = { - 'User-Agent': f'{AUTH_TITLE} ({__url__}, {__version__})', + 'User-Agent': f'{__title_useragent__}/{__version__} (+{__url__})', 'accept': 'application/json', 'authorization': 'Bot ' + TEST_BOT_TOKEN } diff --git a/allianceauth/srp/managers.py b/allianceauth/srp/managers.py index b37d26b2..6e4a69d2 100644 --- a/allianceauth/srp/managers.py +++ b/allianceauth/srp/managers.py @@ -4,7 +4,7 @@ import requests from django.contrib.auth.models import User -from allianceauth import NAME +from allianceauth import __title_useragent__, __url__, __version__ from allianceauth.srp.providers import esi from .models import SrpUserRequest @@ -24,7 +24,7 @@ class SRPManager: def get_kill_data(kill_id): url = ("https://zkillboard.com/api/killID/%s/" % kill_id) headers = { - 'User-Agent': NAME, + 'User-Agent': f'{__title_useragent__}/{__version__} (+{__url__})', 'Content-Type': 'application/json', } r = requests.get(url, headers=headers)