mirror of
https://gitlab.com/allianceauth/allianceauth.git
synced 2025-07-11 21:40:17 +02:00
Remove autogroups if no config for state.
This commit is contained in:
parent
89e5740027
commit
ef9284030b
@ -38,8 +38,14 @@ class AutogroupsConfigManager(models.Manager):
|
||||
"""
|
||||
if state is None:
|
||||
state = user.profile.state
|
||||
for config in self.filter(states=state):
|
||||
config.update_group_membership_for_user(user)
|
||||
configs = self.filter(states=state)
|
||||
if configs:
|
||||
[config.update_group_membership_for_user(user) for config in configs]
|
||||
else:
|
||||
# No config for this user's state. Remove all managed groups.
|
||||
for config in self.all():
|
||||
config.remove_user_from_alliance_groups(user)
|
||||
config.remove_user_from_corp_groups(user)
|
||||
|
||||
|
||||
class AutogroupsConfig(models.Model):
|
||||
|
@ -7,7 +7,7 @@ from . import patch
|
||||
|
||||
class AutogroupsConfigManagerTestCase(TestCase):
|
||||
|
||||
def test_update_groups_for_state(self, ):
|
||||
def test_update_groups_for_state(self):
|
||||
member = AuthUtils.create_member('test member')
|
||||
obj = AutogroupsConfig.objects.create()
|
||||
obj.states.add(member.profile.state)
|
||||
@ -32,3 +32,23 @@ class AutogroupsConfigManagerTestCase(TestCase):
|
||||
self.assertEqual(update_group_membership_for_user.call_count, 1)
|
||||
args, kwargs = update_group_membership_for_user.call_args
|
||||
self.assertEqual(args[0], member)
|
||||
|
||||
@patch('.models.AutogroupsConfig.update_group_membership_for_user')
|
||||
@patch('.models.AutogroupsConfig.remove_user_from_alliance_groups')
|
||||
@patch('.models.AutogroupsConfig.remove_user_from_corp_groups')
|
||||
def test_update_groups_no_config(self, remove_corp, remove_alliance, update_groups):
|
||||
member = AuthUtils.create_member('test member')
|
||||
obj = AutogroupsConfig.objects.create()
|
||||
|
||||
# Corp and alliance groups should be removed from users if their state has no config
|
||||
AutogroupsConfig.objects.update_groups_for_user(member)
|
||||
|
||||
self.assertFalse(update_groups.called)
|
||||
self.assertTrue(remove_alliance.called)
|
||||
self.assertTrue(remove_corp.called)
|
||||
|
||||
# The normal group assignment should occur if there state has a config
|
||||
obj.states.add(member.profile.state)
|
||||
AutogroupsConfig.objects.update_groups_for_user(member)
|
||||
|
||||
self.assertTrue(update_groups.called)
|
||||
|
Loading…
x
Reference in New Issue
Block a user