Mathis/sharp
1
0
Fork 0
mirror of https://github.com/lovell/sharp.git synced 2025-07-09 10:30:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Pass errors as Error instances rather than strings.

Browse Source
This commit is contained in:
Andreas Lind 2014-10-23 08:27:10 +02:00
parent 49b44d8238
commit 1bd316de80
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/metadata.cc
View File

@ -87,7 +87,7 @@ class MetadataWorker : public NanAsyncWorker {
Handle<Value> argv[2] = { NanNull(), NanNull() }; Handle<Value> argv[2] = { NanNull(), NanNull() };
if (!baton->err.empty()) { if (!baton->err.empty()) {
// Error // Error
argv[0] = NanNew<String>(baton->err.data(), baton->err.size()); argv[0] = Exception::Error(NanNew<String>(baton->err.data(), baton->err.size()));
} else { } else {
// Metadata Object // Metadata Object
Local<Object> info = NanNew<Object>(); Local<Object> info = NanNew<Object>();

7
test/unit/metadata.js
View File

@ -185,4 +185,11 @@ describe('Image metadata', function() {
}); });
}); });
it('Report an invalid image as an error', function(done) {
sharp(new Buffer([0x1, 0x2, 0x3, 0x4])).metadata(function (err, metadata) {
assert.ok(err);
assert.ok(err instanceof Error);
done();
});
});
}); });