Mathis/sharp
1
0
Fork 0
mirror of https://github.com/lovell/sharp.git synced 2025-12-19 07:15:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Remove centreSampling option, update some expected test fixtures

Browse Source 
See https://github.com/jcupitt/libvips/issues/705
This commit is contained in:
Lovell Fuller
2017-11-26 13:49:48 +00:00
parent 6aa214181b
commit 2a18b9a8f7
19 changed files with 7 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
test/unit/embed.js
View File

@@ -101,7 +101,7 @@ describe('Embed', function () {
});
});
it('embed TIFF in LAB colourspace onto RGBA background', function (done) {
it.skip('embed TIFF in LAB colourspace onto RGBA background', function (done) {
sharp(fixtures.inputTiffCielab)
.resize(64, 128)
.embed()

2
test/unit/extract.js
View File

@@ -13,7 +13,7 @@ describe('Partial image extraction', function () {
if (err) throw err;
assert.strictEqual(20, info.width);
assert.strictEqual(20, info.height);
fixtures.assertSimilar(fixtures.expected('extract.jpg'), data, { threshold: 8 }, done);
fixtures.assertSimilar(fixtures.expected('extract.jpg'), data, done);
});
});

39
test/unit/resize.js
View File

@@ -386,33 +386,6 @@ describe('Resize dimensions', function () {
});
});
it('Centre vs corner convention return different results', function (done) {
sharp(fixtures.inputJpg)
.resize(32, 24, { centreSampling: false })
.greyscale()
.raw()
.toBuffer(function (err, cornerData) {
if (err) throw err;
assert.strictEqual(768, cornerData.length);
sharp(fixtures.inputJpg)
.resize(32, 24, { centerSampling: true })
.greyscale()
.raw()
.toBuffer(function (err, centreData) {
if (err) throw err;
assert.strictEqual(768, centreData.length);
assert.notStrictEqual(0, cornerData.compare(centreData));
done();
});
});
});
it('Invalid centreSampling option', function () {
assert.throws(function () {
sharp().resize(32, 24, { centreSampling: 1 });
});
});
it('Dimensions that result in differing even shrinks on each axis', function (done) {
sharp(fixtures.inputJpg)
.resize(645, 399)
@@ -451,25 +424,19 @@ describe('Resize dimensions', function () {
it('fastShrinkOnLoad: false ensures image is not shifted', function (done) {
return sharp(fixtures.inputJpgCenteredImage)
.resize(9, 8, {
fastShrinkOnLoad: false,
centreSampling: true
})
.resize(9, 8, { fastShrinkOnLoad: false })
.png()
.toBuffer(function (err, data, info) {
if (err) throw err;
assert.strictEqual(9, info.width);
assert.strictEqual(8, info.height);
// higher threshold makes it pass for both jpeg and jpeg-turbo libs
fixtures.assertSimilar(fixtures.expected('fast-shrink-on-load-false.png'), data, { threshold: 7 }, done);
fixtures.assertSimilar(fixtures.expected('fast-shrink-on-load-false.png'), data, done);
});
});
it('fastShrinkOnLoad: true (default) might result in shifted image', function (done) {
return sharp(fixtures.inputJpgCenteredImage)
.resize(9, 8, {
centreSampling: true
})
.resize(9, 8)
.png()
.toBuffer(function (err, data, info) {
if (err) throw err;