Mathis/sharp
1
0
Fork 0
mirror of https://github.com/lovell/sharp.git synced 2025-07-09 18:40:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fail fast when input Buffer is empty #37

Browse Source
This commit is contained in:
Lovell Fuller 2014-06-02 21:11:25 +01:00
parent 7319533969
commit 46b701c85c
2 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
index.js
View File

@ -24,7 +24,11 @@ var Sharp = function(input) {
if (typeof input === 'string') { if (typeof input === 'string') {
this.options.fileIn = input; this.options.fileIn = input;
} else if (typeof input ==='object' && input instanceof Buffer) { } else if (typeof input ==='object' && input instanceof Buffer) {
this.options.bufferIn = input; if (input.length > 0) {
this.options.bufferIn = input;
} else {
throw 'Buffer is empty';
}
} else { } else {
throw 'Unsupported input ' + typeof input; throw 'Unsupported input ' + typeof input;
} }

17
tests/unit.js
View File

@ -209,12 +209,12 @@ async.series([
}, },
// Rotate to an invalid angle, should fail // Rotate to an invalid angle, should fail
function(done) { function(done) {
var isValid = false; var fail = false;
try { try {
sharp(inputJpg).rotate(1); sharp(inputJpg).rotate(1);
isValid = true; fail = true;
} catch (e) {} } catch (e) {}
assert(!isValid); assert(!fail);
done(); done();
}, },
// Do not enlarge the output if the input width is already less than the output width // Do not enlarge the output if the input width is already less than the output width
@ -252,6 +252,15 @@ async.series([
}).catch(function(err) { }).catch(function(err) {
throw err; throw err;
}); });
},
// Empty Buffer, should fail
function(done) {
var fail = false;
try {
sharp(new Buffer(0));
fail = true;
} catch (e) {}
assert(!fail);
done();
} }
]); ]);