Fail fast for unknown interpolator

index.js

@@ -317,7 +317,18 @@ module.exports.interpolator = {
   vertexSplitQuadraticBasisSpline: 'vsqbs'
 };
 Sharp.prototype.interpolateWith = function(interpolator) {
-  this.options.interpolator = interpolator;
+  var isValid = false;
+  for (var key in module.exports.interpolator) {
+    if (module.exports.interpolator[key] === interpolator) {
+      isValid = true;
+      break;
+    }
+  }
+  if (isValid) {
+    this.options.interpolator = interpolator;
+  } else {
+    throw new Error('Invalid interpolator ' + interpolator);
+  }
   return this;
 };
 

test/unit/interpolation.js

@@ -94,15 +94,13 @@ describe('Interpolation', function() {
   });
 
   it('unknown interpolator throws', function(done) {
-    sharp(fixtures.inputJpg)
+    var isValid = false;
-      .resize(320, 240)
+    try {
-      .interpolateWith('nonexistant')
+      sharp().interpolateWith('nonexistant');
-      .toBuffer()
+      isValid = true;
-      .catch(function (e) {
+    } catch (e) {}
-        assert(
+    assert(!isValid);
-          e.toString().match(/VipsInterpolate: class "nonexistant" not found/)
+    done();
-        );
-      })
-      .finally(done);
   });
+
 });

test/unit/normalize.js

@@ -34,7 +34,7 @@ describe('Normalization', function () {
     sharp(fixtures.inputJpgWithLowContrast)
       .gamma()
       .greyscale()
-      .normalize()
+      .normalize(true)
       .raw()
       .toBuffer(function (err, data, info) {
         if (err) throw err;