Mathis/sharp
1
0
Fork 0
mirror of https://github.com/lovell/sharp.git synced 2025-07-09 18:40:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

Improve error message for missing file that might be SVG

Browse Source
This commit is contained in:
Lovell Fuller 2022-03-02 09:58:55 +00:00
parent 21a960796c
commit af80d7e389
2 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/common.cc
View File

@ -398,6 +398,10 @@ namespace sharp {
// From filesystem // From filesystem
imageType = DetermineImageType(descriptor->file.data()); imageType = DetermineImageType(descriptor->file.data());
if (imageType == ImageType::MISSING) { if (imageType == ImageType::MISSING) {
if (descriptor->file.find("<svg") != std::string::npos) {
throw vips::VError("Input file is missing, did you mean "
"sharp(Buffer.from('" + descriptor->file.substr(0, 8) + "...')?");
}
throw vips::VError("Input file is missing"); throw vips::VError("Input file is missing");
} }
if (imageType != ImageType::UNKNOWN) { if (imageType != ImageType::UNKNOWN) {

7
test/unit/svg.js
View File

@ -135,4 +135,11 @@ describe('SVG input', function () {
assert.strictEqual(info.height, 240); assert.strictEqual(info.height, 240);
assert.strictEqual(info.channels, 4); assert.strictEqual(info.channels, 4);
}); });
it('Detects SVG passed as a string', () =>
assert.rejects(
() => sharp('<svg></svg>').toBuffer(),
/Input file is missing, did you mean/
)
);
}); });