Prevent possible race condition when reading metadata #3451

2025-12-19 15:25:07 +01:00 · 2022-11-13 10:04:55 +00:00
parent 3a64a0529a
commit df971207b8
3 changed files with 25 additions and 2 deletions
--- a/lib/input.js
+++ b/lib/input.js
@@ -469,7 +469,7 @@ function metadata (callback) {
  } else {
    if (this._isStreamInput()) {
      return new Promise((resolve, reject) => {
-        this.on('finish', () => {
+        const finished = () => {
          this._flattenBufferIn();
          sharp.metadata(this.options, (err, metadata) => {
            if (err) {
@@ -478,7 +478,12 @@ function metadata (callback) {
              resolve(metadata);
            }
          });
-        });
+        };
+        if (this.writableFinished) {
+          finished();
+        } else {
+          this.once('finish', finished);
+        }
      });
    } else {
      return new Promise((resolve, reject) => {