Mathis/sharp
1
0
Fork 0
mirror of https://github.com/lovell/sharp.git synced 2025-12-19 07:15:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

Simplify ICC processing when retaining input profiles #4468

Browse Source 
Takes advantage of libvips' improved ICC handling
This commit is contained in:
Lovell Fuller
2025-11-04 15:06:49 +00:00
parent 4f9f8179a6
commit e1628d8ef5
5 changed files with 38 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
test/unit/metadata.js
View File

@@ -651,16 +651,27 @@ describe('Image metadata', () => {
assert.strictEqual(description, 'Generic RGB Profile');
});
it('keep existing ICC profile, ignore colourspace conversion', async () => {
it('keep existing CMYK input profile for CMYK output', async () => {
const data = await sharp(fixtures.inputJpgWithCmykProfile)
.keepIccProfile()
.toColourspace('cmyk')
.toBuffer();
const metadata = await sharp(data).metadata();
assert.strictEqual(metadata.channels, 4);
const { description } = icc.parse(metadata.icc);
assert.strictEqual(description, 'U.S. Web Coated (SWOP) v2');
});
it('transform with but discard existing RGB input profile for CMYK output', async () => {
const data = await sharp(fixtures.inputJpgWithExif)
.keepIccProfile()
.toColourspace('cmyk')
.toBuffer();
const metadata = await sharp(data).metadata();
assert.strictEqual(metadata.channels, 3);
const { description } = icc.parse(metadata.icc);
assert.strictEqual(description, 'Generic RGB Profile');
assert.strictEqual(metadata.channels, 4);
assert.strictEqual(metadata.icc, undefined);
});
it('keep existing ICC profile, avoid colour transform', async () => {