Mathis/sharp
1
0
Fork 0
mirror of https://github.com/lovell/sharp.git synced 2025-07-09 10:30:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

Allow instance reuse with differing toBuffer options (#1860)

Browse Source
This commit is contained in:
Raboliot le gris 2019-09-08 15:35:16 +02:00 committed by Lovell Fuller
parent 69fe21a7ec
commit fb5c393fbd
3 changed files with 22 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
.gitignore vendored
View File

@ -14,3 +14,4 @@ vendor
.nyc_output .nyc_output
.vscode/ .vscode/
package-lock.json package-lock.json
.idea

2
lib/output.js
View File

@ -92,6 +92,8 @@ function toFile (fileOut, callback) {
function toBuffer (options, callback) { function toBuffer (options, callback) {
if (is.object(options)) { if (is.object(options)) {
this._setBooleanOption('resolveWithObject', options.resolveWithObject); this._setBooleanOption('resolveWithObject', options.resolveWithObject);
} else if (this.options.resolveWithObject) {
this.options.resolveWithObject = false;
} }
return this._pipeline(is.fn(options) ? options : callback); return this._pipeline(is.fn(options) ? options : callback);
} }

19
test/unit/toBuffer.js Normal file
View File

@ -0,0 +1,19 @@
'use strict';
const assert = require('assert');
const sharp = require('../../');
const fixtures = require('../fixtures');
describe('toBuffer', () => {
it('reusing same sharp object does not reset previously passed parameters to toBuffer', (done) => {
let image = sharp(fixtures.inputJpg);
image.toBuffer({ resolveWithObject: true }).then((obj) => {
image.toBuffer().then((buff) => {
assert.strict.equal(Buffer.isBuffer(buff), true);
assert.strict.equal(typeof obj, 'object');
done();
});
});
});
});