mirror of
https://github.com/lovell/sharp.git
synced 2025-07-09 10:30:15 +02:00
1a563360c6
Fixes couple of minor issues with JP2 errors:
1. The tests passed as false-positives even if regex is changed to arbitary pattern, because the promise returned from `assert.rejects` was ignored and the test ended prematurely. This is fixed by removing `{ ... }` around the test function body.
2. This, in turn, hid an issue with `toFile` not throwing the expected error message which was instead propagating `Error: VipsOperation: class "jp2ksave" not found` from libvips. This is now fixed by manually checking the extension before calling into libvips.
3. Pre-creating error instances like `errJp2Save` did is sometimes tempting, but is problematic for debugging because it hides the actual stacktrace of the error (the stacktrace is collected at the moment of `new Error` creation). This is now turned into a function that creates error with the right stack.
93 lines
3.4 KiB
JavaScript
93 lines
3.4 KiB
JavaScript
'use strict';
|
|
|
|
const fs = require('fs');
|
|
const assert = require('assert');
|
|
|
|
const sharp = require('../../');
|
|
const fixtures = require('../fixtures');
|
|
|
|
describe('JP2 output', () => {
|
|
if (!sharp.format.jp2k.input.buffer) {
|
|
it('JP2 output should fail due to missing OpenJPEG', () =>
|
|
assert.rejects(async () =>
|
|
sharp(fixtures.inputJpg)
|
|
.jp2()
|
|
.toBuffer(),
|
|
/JP2 output requires libvips with support for OpenJPEG/
|
|
)
|
|
);
|
|
|
|
it('JP2 file output should fail due to missing OpenJPEG', () =>
|
|
assert.rejects(async () => sharp(fixtures.inputJpg).toFile('test.jp2'),
|
|
/JP2 output requires libvips with support for OpenJPEG/
|
|
)
|
|
);
|
|
} else {
|
|
it('JP2 Buffer to PNG Buffer', () => {
|
|
sharp(fs.readFileSync(fixtures.inputJp2))
|
|
.resize(8, 15)
|
|
.png()
|
|
.toBuffer({ resolveWithObject: true })
|
|
.then(({ data, info }) => {
|
|
assert.strictEqual(true, data.length > 0);
|
|
assert.strictEqual(data.length, info.size);
|
|
assert.strictEqual('png', info.format);
|
|
assert.strictEqual(8, info.width);
|
|
assert.strictEqual(15, info.height);
|
|
assert.strictEqual(4, info.channels);
|
|
});
|
|
});
|
|
|
|
it('JP2 quality', function (done) {
|
|
sharp(fixtures.inputJp2)
|
|
.resize(320, 240)
|
|
.jp2({ quality: 70 })
|
|
.toBuffer(function (err, buffer70) {
|
|
if (err) throw err;
|
|
sharp(fixtures.inputJp2)
|
|
.resize(320, 240)
|
|
.toBuffer(function (err, buffer80) {
|
|
if (err) throw err;
|
|
assert(buffer70.length < buffer80.length);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
it('Without chroma subsampling generates larger file', function (done) {
|
|
// First generate with chroma subsampling (default)
|
|
sharp(fixtures.inputJp2)
|
|
.resize(320, 240)
|
|
.jp2({ chromaSubsampling: '4:2:0' })
|
|
.toBuffer(function (err, withChromaSubsamplingData, withChromaSubsamplingInfo) {
|
|
if (err) throw err;
|
|
assert.strictEqual(true, withChromaSubsamplingData.length > 0);
|
|
assert.strictEqual(withChromaSubsamplingData.length, withChromaSubsamplingInfo.size);
|
|
assert.strictEqual('jp2', withChromaSubsamplingInfo.format);
|
|
assert.strictEqual(320, withChromaSubsamplingInfo.width);
|
|
assert.strictEqual(240, withChromaSubsamplingInfo.height);
|
|
// Then generate without
|
|
sharp(fixtures.inputJp2)
|
|
.resize(320, 240)
|
|
.jp2({ chromaSubsampling: '4:4:4' })
|
|
.toBuffer(function (err, withoutChromaSubsamplingData, withoutChromaSubsamplingInfo) {
|
|
if (err) throw err;
|
|
assert.strictEqual(true, withoutChromaSubsamplingData.length > 0);
|
|
assert.strictEqual(withoutChromaSubsamplingData.length, withoutChromaSubsamplingInfo.size);
|
|
assert.strictEqual('jp2', withoutChromaSubsamplingInfo.format);
|
|
assert.strictEqual(320, withoutChromaSubsamplingInfo.width);
|
|
assert.strictEqual(240, withoutChromaSubsamplingInfo.height);
|
|
assert.strictEqual(true, withChromaSubsamplingData.length <= withoutChromaSubsamplingData.length);
|
|
done();
|
|
});
|
|
});
|
|
});
|
|
|
|
it('Invalid JP2 chromaSubsampling value throws error', function () {
|
|
assert.throws(function () {
|
|
sharp().jpeg({ chromaSubsampling: '4:2:2' });
|
|
});
|
|
});
|
|
}
|
|
});
|