From 3d3bc8580a350414d33d0bea39ad3fe8fca67a7c Mon Sep 17 00:00:00 2001 From: Mathis Date: Thu, 25 Apr 2024 13:46:08 +0200 Subject: [PATCH] feat(services): update category.service with improved UUID usage and new function The commit updates the 'category.service.ts' file by refactoring the UUID usage. Previously, the UUID feature was imported as a whole, but now only the v4 function is imported for efficiency. It introduces a new function 'getAllCategory' to fetch all categories. This, combined with better error handling and logging, leads to improved service reliability. Issue: #11 Signed-off-by: Mathis --- src/services/category.service.ts | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/src/services/category.service.ts b/src/services/category.service.ts index 4100c90..d69829d 100644 --- a/src/services/category.service.ts +++ b/src/services/category.service.ts @@ -1,6 +1,6 @@ //FEAT Create new category import type IDbCategory from "@interfaces/database/IDbCategory"; -import * as uuid from 'uuid' +import { v4 as uuidv4 } from 'uuid'; import {Logger} from "tslog"; import MysqlService from "@services/mysql.service"; @@ -20,17 +20,26 @@ async function createCategory(data: IDbCategory): Promise { logger.info(`Creating a new category... (${data.display_name})`) try { return await MysqlService.Category.insert(DbHandler, { - id: uuid.v4(undefined, undefined, undefined), + id: uuidv4(), display_name: data.display_name, slug_name: data.slug_name }) - } catch (e) { - logger.error(`Error creating category: ${e.message}`); + } catch (error) { + logger.error(`Error creating category: ${error}`); return; } } //FEAT Get all categories +async function getAllCategory() { + try { + logger.info("Getting all categories..."); + return await MysqlService.Category.getAll(DbHandler); + } catch (error) { + logger.error(`Error getting all categories: ${error}`); + return; + } +} //FEAT Get a category (slug) @@ -41,7 +50,8 @@ async function createCategory(data: IDbCategory): Promise { //FEAT Delete a category (id) const CategoryService = { - create: createCategory + create: createCategory, + getAll: getAllCategory } export default CategoryService; \ No newline at end of file