WorkSimplon/brief-05-back
2
0
Fork 0
Code Issues Pull Requests Packages Projects 1 Releases Wiki Activity

feat(services): update user service

Browse Source 
- Moved import statement to top for better organization.
- Removed unnecessary comments and lines.
- Simplified return statements for clarity and efficiency.
- Streamlined deletion process by directly returning the result.

Signed-off-by: Mathis <yidhra@tuta.io>
This commit is contained in:
Mathis H (Avnyr) 2024-05-02 15:40:48 +02:00
parent bdfc598218
commit 62742e6afe
Signed by: Mathis
GPG Key ID: DD9E0666A747D126
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/services/user.service.ts
View File

@ -2,13 +2,13 @@ import type { IDbUser } from "@interfaces/database/IDbUser";
import type { IReqLogin } from "@interfaces/requests/IReqLogin";
import type { IReqRegister } from "@interfaces/requests/IReqRegister";
import { ErrorType, type ISError } from "@interfaces/services/ISError";
import type { IUserUpdate } from "@interfaces/services/IUserUpdate";
import CredentialService from "@services/credential.service";
import JwtService from "@services/jwt.service";
import MySqlService from "@services/mysql.service";
import { isDebugMode } from "@utils/debugState";
import { Logger } from "tslog";
import { v4 } from "uuid";
import {IUserUpdate} from "@interfaces/services/IUserUpdate";
const logger = new Logger({
name: "UserService",
@ -99,7 +99,6 @@ DbHandler.factorize({
logger.trace(`\n\n> ${result._valuesArray.join(', ')}\n\n> ${result.totalFields}\n\n> ${result._keysTemplate}\n`)
})*/
//ToTest
/**
* Registers a new user.
*
@ -164,7 +163,7 @@ async function register(inputData: IReqRegister): Promise<ISError | string> {
);
// JWT
const token = await JwtService.sign(
return await JwtService.sign(
{
sub: currentId,
},
@ -174,7 +173,6 @@ async function register(inputData: IReqRegister): Promise<ISError | string> {
"1d",
"user",
);
return token;
} catch (err) {
logger.error(`\n\n${err}\n`);
return {
@ -184,7 +182,6 @@ async function register(inputData: IReqRegister): Promise<ISError | string> {
}
}
//ToTest
/**
* Logs in a user with the provided input data.
*
@ -331,9 +328,8 @@ async function editUserService(
async function deleteUserService(targetId: string): Promise<boolean> {
logger.info(`Deleting user ${targetId}`);
try {
const DeleteResult = await MySqlService.User.delete(DbHandler, targetId)
if (DeleteResult.affectedRows !== 0) return true;
return false;
const DeleteResult = await MySqlService.User.delete(DbHandler, targetId);
return DeleteResult.affectedRows !== 0;
} catch (e) {
logger.warn(e);
return false;