WorkSimplon/brief-05-back
2
0
Fork 0
Code Issues Pull Requests Packages Projects 1 Releases Wiki Activity

Compare commits

base: WorkSimplon:ec53fcb2479cccfc79d277d1087b91353cdd44a1
Branches Tags
WorkSimplon:main
WorkSimplon:deadline
...
compare: WorkSimplon:30c6f2e3f156f904db43b178ec10eb7df1c408bb
Branches Tags
WorkSimplon:deadline
WorkSimplon:main

3 Commits
ec53fcb247 ... 30c6f2e3f1

Author SHA1 Message Date
Mathis
30c6f2e3f1
feat(services): remove unused import from rent.service.ts 
The `body` import from "express-validator" has been removed from rent.service.ts as it was not used. Also, an error handler for deleting rent was updated to always return false on encountering an error, improving the error handling mechanism.

Issue: #24
Signed-off-by: Mathis <yidhra@tuta.io>
 2024-05-03 12:02:36 +02:00
Mathis
b47ec6c440
feat(services): add error logging in rent.service 
A logging feature is added in the `rent.service.ts` to log any errors when attempting to delete rent. This feature helps in diagnosing issues during rent deletion.

Issue: #24
Signed-off-by: Mathis <yidhra@tuta.io>
 2024-05-03 12:01:56 +02:00
Mathis
b4f200cb32
feat(inspectionProfiles): increase TypeScript code redundancy threshold 
The minimum size for the TypeScript language in the duplicated code check has been increased. This update reduces the sensitivity of the code redundancy inspection, potentially reducing false positive results.

Signed-off-by: Mathis <yidhra@tuta.io>
 2024-05-03 12:01:03 +02:00
2 changed files with 4 additions and 2 deletions
Show Stats Expand all files Collapse all files

2
.idea/inspectionProfiles/Project_Default.xml generated
View File

@ -3,7 +3,7 @@
<option name="myName" value="Project Default" /> <option name="myName" value="Project Default" />
<inspection_tool class="DuplicatedCode" enabled="true" level="WEAK WARNING" enabled_by_default="true"> <inspection_tool class="DuplicatedCode" enabled="true" level="WEAK WARNING" enabled_by_default="true">
<Languages> <Languages>
<language minSize="114" name="TypeScript" /> <language minSize="174" name="TypeScript" />
</Languages> </Languages>
</inspection_tool> </inspection_tool>
</profile> </profile>

4
src/services/rent.service.ts
View File

@ -4,7 +4,6 @@ import { isDebugMode } from "@utils/debugState";
import { Logger } from "tslog"; import { Logger } from "tslog";
import { v4 } from "uuid"; import { v4 } from "uuid";
import IDbRent from "@interfaces/database/IDbRent"; import IDbRent from "@interfaces/database/IDbRent";
import {body} from "express-validator";
const logger = new Logger({ const logger = new Logger({
name: "RentService", name: "RentService",
@ -146,6 +145,9 @@ async function deleteRentService(rentId: string) {
return true; return true;
} }
return false; return false;
} catch (error) {
logger.error(`\n\n> Error deleting rent: \n${error}\n`);
return false
} }
} }