From 4e7d99e7ee46118e308191215b9fb2caf18c6ab0 Mon Sep 17 00:00:00 2001
From: Chuck Walbourn <walbourn@users.noreply.github.com>
Date: Fri, 28 Mar 2025 17:23:40 -0700
Subject: [PATCH] Code review feedback for DLL declimport/export (#601)

---
 .azuredevops/policies/approvercountpolicy.yml | 20 +++++++++++++++++++
 DirectXTex/DirectXTex.h                       | 12 +++++++++--
 2 files changed, 30 insertions(+), 2 deletions(-)
 create mode 100644 .azuredevops/policies/approvercountpolicy.yml

diff --git a/.azuredevops/policies/approvercountpolicy.yml b/.azuredevops/policies/approvercountpolicy.yml
new file mode 100644
index 0000000..d8a3f4b
--- /dev/null
+++ b/.azuredevops/policies/approvercountpolicy.yml
@@ -0,0 +1,20 @@
+name: approver_count
+description: Approver count policy for mscodehub/DirectXTex/DirectXTex repository
+resource: repository
+where: 
+configuration:
+  approverCountPolicySettings:
+    isBlocking: true
+    requireMinimumApproverCount: 1
+    creatorVoteCounts: false
+    allowDownvotes: false
+    sourcePushOptions:
+      resetOnSourcePush: false
+      requireVoteOnLastIteration: true
+      requireVoteOnEachIteration: false
+      resetRejectionsOnSourcePush: false
+    blockLastPusherVote: true
+    branchNames:
+    - refs/heads/release
+    - refs/heads/main
+    displayName: mscodehub/DirectXTex/DirectXTex Approver Count Policy
diff --git a/DirectXTex/DirectXTex.h b/DirectXTex/DirectXTex.h
index 94b6e9a..4ecf5c7 100644
--- a/DirectXTex/DirectXTex.h
+++ b/DirectXTex/DirectXTex.h
@@ -49,10 +49,18 @@ struct IWICMetadataQueryReader;
 
 #define DIRECTX_TEX_VERSION 207
 
-#ifdef DIRECTX_TEX_EXPORT
+#if defined(_WIN32) && defined(DIRECTX_TEX_EXPORT)
+#ifdef __GNUC__
+#define DIRECTX_TEX_API __attribute__ ((dllexport))
+#else
 #define DIRECTX_TEX_API __declspec(dllexport)
-#elif defined(DIRECTX_TEX_IMPORT)
+#endif
+#elif defined(_WIN32) && defined(DIRECTX_TEX_IMPORT)
+#ifdef __GNUC__
+#define DIRECTX_TEX_API __attribute__ ((dllimport))
+#else
 #define DIRECTX_TEX_API __declspec(dllimport)
+#endif
 #else
 #define DIRECTX_TEX_API
 #endif