Yidhra/DirectXTex
2
0
Fork 0
mirror of https://github.com/microsoft/DirectXTex.git synced 2025-07-13 13:40:14 +02:00
Code Issues Actions Packages Projects Releases Wiki Activity

Code review feedback

Browse Source
This commit is contained in:
Chuck Walbourn 2022-03-14 02:48:00 -07:00
parent 5a1d284615
commit f8b0a959b9
1 changed files with 4 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
DirectXTex/BC6HBC7.cpp
View File

@ -1180,7 +1180,6 @@ namespace
//------------------------------------------------------------------------------------- //-------------------------------------------------------------------------------------
template<bool ishdr>
float OptimizeRGB( float OptimizeRGB(
_In_reads_(NUM_PIXELS_PER_BLOCK) const HDRColorA* const pPoints, _In_reads_(NUM_PIXELS_PER_BLOCK) const HDRColorA* const pPoints,
_Out_ HDRColorA* pX, _Out_ HDRColorA* pX,
@ -1194,21 +1193,8 @@ namespace
const float *pD = (3 == cSteps) ? pD3 : pD4; const float *pD = (3 == cSteps) ? pD3 : pD4;
// Find Min and Max points, as starting point // Find Min and Max points, as starting point
HDRColorA X, Y; HDRColorA X(FLT_MAX, FLT_MAX, FLT_MAX, 0.0f);
#if (__cplusplus >= 201703L) HDRColorA Y(-FLT_MAX, -FLT_MAX, -FLT_MAX, 0.0f);
if constexpr (ishdr)
#else
if (ishdr)
#endif
{
X = HDRColorA{ FLT_MAX, FLT_MAX, FLT_MAX, 0.0f };
Y = HDRColorA{ -FLT_MAX, -FLT_MAX, -FLT_MAX, 0.0f };
}
else
{
X = HDRColorA{ 1.0f, 1.0f, 1.0f, 0.0f };
Y = HDRColorA{ 0.0f, 0.0f, 0.0f, 0.0f };
}
for (size_t iPoint = 0; iPoint < cPixels; iPoint++) for (size_t iPoint = 0; iPoint < cPixels; iPoint++)
{ {
@ -2506,7 +2492,7 @@ float D3DX_BC6H::RoughMSE(EncodeParams* pEP) const noexcept
} }
HDRColorA epA, epB; HDRColorA epA, epB;
OptimizeRGB<true>(pEP->aHDRPixels, &epA, &epB, 4, np, auPixIdx); OptimizeRGB(pEP->aHDRPixels, &epA, &epB, 4, np, auPixIdx);
aEndPts[p].A.Set(epA, pEP->bSigned); aEndPts[p].A.Set(epA, pEP->bSigned);
aEndPts[p].B.Set(epB, pEP->bSigned); aEndPts[p].B.Set(epB, pEP->bSigned);
if (pEP->bSigned) if (pEP->bSigned)
@ -3478,7 +3464,7 @@ float D3DX_BC7::RoughMSE(EncodeParams* pEP, size_t uShape, size_t uIndexMode) no
} }
HDRColorA epA, epB; HDRColorA epA, epB;
OptimizeRGB<false>(pEP->aHDRPixels, &epA, &epB, 4, np, auPixIdx); OptimizeRGB(pEP->aHDRPixels, &epA, &epB, 4, np, auPixIdx);
epA.Clamp(0.0f, 1.0f); epA.Clamp(0.0f, 1.0f);
epB.Clamp(0.0f, 1.0f); epB.Clamp(0.0f, 1.0f);
epA *= 255.0f; epA *= 255.0f;