Mathis/allianceauth
1
0
Fork 0
mirror of https://gitlab.com/allianceauth/allianceauth.git synced 2025-07-12 22:10:16 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fixed incorrect parameters for task apply call (#680)

Browse Source 
Added test to ensure member groups are correctly applied after
`activate_mumble` is called.
This commit is contained in:
Basraah 2017-01-29 10:46:51 +10:00 committed by GitHub
parent 3d645867bb
commit 13204a7e91
2 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
services/modules/mumble/tests.py
View File

@ -147,6 +147,7 @@ class MumbleViewsTestCase(TestCase):
self.assertEqual(mumble_user.username, expected_username) self.assertEqual(mumble_user.username, expected_username)
self.assertTrue(mumble_user.pwhash) self.assertTrue(mumble_user.pwhash)
self.assertEqual(self.member.mumble.username, expected_username) self.assertEqual(self.member.mumble.username, expected_username)
self.assertEqual('Member', mumble_user.groups)
def test_deactivate(self): def test_deactivate(self):
self.login() self.login()

2
services/modules/mumble/views.py
View File

@ -41,7 +41,7 @@ def activate_mumble(request):
if result: if result:
logger.debug("Updated authserviceinfo for user %s with mumble credentials. Updating groups." % request.user) logger.debug("Updated authserviceinfo for user %s with mumble credentials. Updating groups." % request.user)
MumbleTasks.update_groups.apply(request.user.pk) # Run synchronously to prevent timing issues MumbleTasks.update_groups.apply(args=(request.user.pk,)) # Run synchronously to prevent timing issues
logger.info("Successfully activated mumble for user %s" % request.user) logger.info("Successfully activated mumble for user %s" % request.user)
messages.success(request, 'Activated Mumble account.') messages.success(request, 'Activated Mumble account.')
credentials = { credentials = {