mirror of
https://gitlab.com/allianceauth/allianceauth.git
synced 2025-07-09 04:20:17 +02:00
Add unit tests for eveonline providers and fix coverage counting
This commit is contained in:
Erik Kalkoken
colcrunch
parent
99492e9c34
commit
9970e5535b
@ -8,6 +8,8 @@ omit =
|
||||
*/example/*
|
||||
*/project_template/*
|
||||
*/bin/*
|
||||
*/tests/*
|
||||
*/tests.py
|
||||
|
||||
[report]
|
||||
exclude_lines =
|
||||
|
||||
545
allianceauth/eveonline/tests/test_providers.py
Normal file
545
allianceauth/eveonline/tests/test_providers.py
Normal file
@ -0,0 +1,545 @@
|
||||
from unittest.mock import Mock, patch
|
||||
|
||||
from bravado.exception import HTTPNotFound, HTTPUnprocessableEntity
|
||||
from django.test import TestCase
|
||||
|
||||
from ..models import EveCharacter, EveCorporationInfo, EveAllianceInfo
|
||||
from ..providers import ObjectNotFound, Entity, Character, Corporation, \
|
||||
Alliance, ItemType, EveProvider, EveSwaggerProvider
|
||||
|
||||
|
||||
class TestObjectNotFound(TestCase):
|
||||
|
||||
def test_str(self):
|
||||
x = ObjectNotFound(1001, 'Character')
|
||||
self.assertEqual(str(x), 'Character with ID 1001 not found.')
|
||||
|
||||
|
||||
class TestEntity(TestCase):
|
||||
|
||||
def test_str(self):
|
||||
x = Entity(1001, 'Bruce Wayne')
|
||||
self.assertEqual(str(x), 'Bruce Wayne')
|
||||
|
||||
# bug - does not return a string
|
||||
"""
|
||||
x = Entity(1001)
|
||||
self.assertEqual(str(x), '')
|
||||
|
||||
x = Entity()
|
||||
self.assertEqual(str(x), '')
|
||||
"""
|
||||
|
||||
def test_repr(self):
|
||||
x = Entity(1001, 'Bruce Wayne')
|
||||
self.assertEqual(repr(x), '<Entity (1001): Bruce Wayne>')
|
||||
|
||||
x = Entity(1001)
|
||||
self.assertEqual(repr(x), '<Entity (1001): None>')
|
||||
|
||||
x = Entity()
|
||||
self.assertEqual(repr(x), '<Entity (None): None>')
|
||||
|
||||
|
||||
def test_bool(self):
|
||||
x = Entity(1001)
|
||||
self.assertTrue(bool(x))
|
||||
|
||||
x = Entity()
|
||||
self.assertFalse(bool(x))
|
||||
|
||||
def test_eq(self):
|
||||
x1 = Entity(1001)
|
||||
x2 = Entity(1001)
|
||||
y = Entity(1002)
|
||||
z1 = Entity()
|
||||
z2 = Entity()
|
||||
|
||||
self.assertEqual(x1, x2)
|
||||
self.assertNotEqual(x1, y)
|
||||
self.assertNotEqual(x1, z1)
|
||||
self.assertEqual(z1, z2)
|
||||
|
||||
# bug: missing _neq_ in Equity to compliment _eq_
|
||||
|
||||
|
||||
class TestCorporation(TestCase):
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_alliance')
|
||||
def test_alliance_defined(self, mock_provider_get_alliance):
|
||||
my_alliance = Alliance(
|
||||
id=3001,
|
||||
name='Dummy Alliance',
|
||||
ticker='Dummy',
|
||||
corp_ids=[2001, 2002, 2003],
|
||||
executor_corp_id=2001
|
||||
)
|
||||
mock_provider_get_alliance.return_value = my_alliance
|
||||
|
||||
x = Corporation(alliance_id=3001)
|
||||
self.assertEqual(
|
||||
x.alliance,
|
||||
my_alliance
|
||||
)
|
||||
self.assertEqual(
|
||||
x.alliance,
|
||||
my_alliance
|
||||
)
|
||||
# should fetch alliance once only
|
||||
self.assertEqual(mock_provider_get_alliance.call_count, 1)
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_alliance')
|
||||
def test_alliance_not_defined(self, mock_provider_get_alliance):
|
||||
mock_provider_get_alliance.return_value = None
|
||||
|
||||
x = Corporation()
|
||||
self.assertEqual(
|
||||
x.alliance,
|
||||
Entity(None, None)
|
||||
)
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_character')
|
||||
def test_ceo(self, mock_provider_get_character):
|
||||
my_ceo = Character(
|
||||
id=1001,
|
||||
name='Bruce Wayne',
|
||||
corp_id=2001,
|
||||
alliance_id=3001
|
||||
)
|
||||
mock_provider_get_character.return_value = my_ceo
|
||||
|
||||
# fetch from provider if not defined
|
||||
x = Corporation()
|
||||
self.assertEqual(
|
||||
x.ceo,
|
||||
my_ceo
|
||||
)
|
||||
|
||||
# return existing if defined
|
||||
mock_provider_get_character.return_value = None
|
||||
self.assertEqual(
|
||||
x.ceo,
|
||||
my_ceo
|
||||
)
|
||||
self.assertEqual(mock_provider_get_character.call_count, 1)
|
||||
|
||||
# bug in ceo(): will try to fetch character even if ceo_id is None
|
||||
|
||||
|
||||
class TestAlliance(TestCase):
|
||||
|
||||
def setUp(self):
|
||||
self.my_alliance = Alliance(
|
||||
id=3001,
|
||||
name='Dummy Alliance',
|
||||
ticker='Dummy',
|
||||
corp_ids=[2001, 2002, 2003],
|
||||
executor_corp_id=2001
|
||||
)
|
||||
|
||||
@staticmethod
|
||||
def _get_corp(corp_id):
|
||||
corps = {
|
||||
2001: Corporation(
|
||||
id=2001,
|
||||
name='Dummy Corp 1',
|
||||
alliance_id=3001
|
||||
),
|
||||
2002: Corporation(
|
||||
id=2002,
|
||||
name='Dummy Corp 2',
|
||||
alliance_id=3001
|
||||
),
|
||||
2003: Corporation(
|
||||
id=2003,
|
||||
name='Dummy Corp 3',
|
||||
alliance_id=3001
|
||||
),
|
||||
}
|
||||
|
||||
if corp_id:
|
||||
return corps[int(corp_id)]
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_corp')
|
||||
def test_corp(self, mock_provider_get_corp):
|
||||
mock_provider_get_corp.side_effect = TestAlliance._get_corp
|
||||
|
||||
# should fetch corp if not in the object
|
||||
self.assertEqual(
|
||||
self.my_alliance.corp(2001),
|
||||
TestAlliance._get_corp(2001)
|
||||
)
|
||||
# should fetch corp if not in the object
|
||||
self.assertEqual(
|
||||
self.my_alliance.corp(2002),
|
||||
TestAlliance._get_corp(2002)
|
||||
)
|
||||
# should return from the object if its there
|
||||
self.assertEqual(
|
||||
self.my_alliance.corp(2001),
|
||||
TestAlliance._get_corp(2001)
|
||||
)
|
||||
# should return from the object if its there
|
||||
self.assertEqual(
|
||||
self.my_alliance.corp(2002),
|
||||
TestAlliance._get_corp(2002)
|
||||
)
|
||||
# should be called once by used corp only
|
||||
self.assertEqual(mock_provider_get_corp.call_count, 2)
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_corp')
|
||||
def test_corps(self, mock_provider_get_corp):
|
||||
mock_provider_get_corp.side_effect = TestAlliance._get_corp
|
||||
|
||||
self.assertEqual(
|
||||
self.my_alliance.corps,
|
||||
[
|
||||
TestAlliance._get_corp(2001),
|
||||
TestAlliance._get_corp(2002),
|
||||
TestAlliance._get_corp(2003),
|
||||
]
|
||||
)
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_corp')
|
||||
def test_executor_corp(self, mock_provider_get_corp):
|
||||
mock_provider_get_corp.side_effect = TestAlliance._get_corp
|
||||
|
||||
self.assertEqual(
|
||||
self.my_alliance.executor_corp,
|
||||
TestAlliance._get_corp(2001),
|
||||
)
|
||||
|
||||
x = Alliance()
|
||||
self.assertEqual(
|
||||
x.executor_corp,
|
||||
Entity(None, None),
|
||||
)
|
||||
|
||||
|
||||
class TestCharacter(TestCase):
|
||||
|
||||
def setUp(self):
|
||||
self.my_character = Character(
|
||||
id=1001,
|
||||
name='Bruce Wayne',
|
||||
corp_id=2001,
|
||||
alliance_id=3001
|
||||
)
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_corp')
|
||||
def test_corp(self, mock_provider_get_corp):
|
||||
my_corp = Corporation(
|
||||
id=2001,
|
||||
name='Dummy Corp 1'
|
||||
)
|
||||
mock_provider_get_corp.return_value = my_corp
|
||||
|
||||
self.assertEqual(self.my_character.corp, my_corp)
|
||||
self.assertEqual(self.my_character.corp, my_corp)
|
||||
|
||||
# should call the provider one time only
|
||||
self.assertEqual(mock_provider_get_corp.call_count, 1)
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_alliance')
|
||||
@patch('allianceauth.eveonline.providers.EveSwaggerProvider.get_corp')
|
||||
def test_alliance_has_one(
|
||||
self,
|
||||
mock_provider_get_corp,
|
||||
mock_provider_get_alliance,
|
||||
):
|
||||
my_corp = Corporation(
|
||||
id=2001,
|
||||
name='Dummy Corp 1',
|
||||
alliance_id=3001
|
||||
)
|
||||
mock_provider_get_corp.return_value = my_corp
|
||||
my_alliance = Alliance(
|
||||
id=3001,
|
||||
name='Dummy Alliance 1',
|
||||
executor_corp_id=2001,
|
||||
corp_ids=[2001, 2002]
|
||||
)
|
||||
mock_provider_get_alliance.return_value = my_alliance
|
||||
|
||||
self.assertEqual(self.my_character.alliance, my_alliance)
|
||||
self.assertEqual(self.my_character.alliance, my_alliance)
|
||||
|
||||
# should call the provider one time only
|
||||
self.assertEqual(mock_provider_get_corp.call_count, 1)
|
||||
self.assertEqual(mock_provider_get_alliance.call_count, 1)
|
||||
|
||||
|
||||
def test_alliance_has_none(self):
|
||||
self.my_character.alliance_id = None
|
||||
self.assertEqual(self.my_character.alliance, Entity(None, None))
|
||||
|
||||
|
||||
class TestItemType(TestCase):
|
||||
|
||||
def test_init(self):
|
||||
x = ItemType(id=99, name='Dummy Item')
|
||||
self.assertIsInstance(x, ItemType)
|
||||
|
||||
|
||||
class TestEveProvider(TestCase):
|
||||
|
||||
def setUp(self):
|
||||
self.my_provider = EveProvider()
|
||||
|
||||
def test_get_alliance(self):
|
||||
with self.assertRaises(NotImplementedError):
|
||||
self.my_provider.get_alliance(3001)
|
||||
|
||||
def test_get_corp(self):
|
||||
with self.assertRaises(NotImplementedError):
|
||||
self.my_provider.get_corp(2001)
|
||||
|
||||
def test_get_character(self):
|
||||
with self.assertRaises(NotImplementedError):
|
||||
self.my_provider.get_character(1001)
|
||||
|
||||
# bug: should be calling NotImplementedError() not NotImplemented
|
||||
"""
|
||||
def test_get_itemtype(self):
|
||||
with self.assertRaises(NotImplementedError):
|
||||
self.my_provider.get_itemtype(4001)
|
||||
"""
|
||||
|
||||
|
||||
class TestEveSwaggerProvider(TestCase):
|
||||
|
||||
|
||||
@staticmethod
|
||||
def esi_get_alliances_alliance_id(alliance_id):
|
||||
alliances = {
|
||||
3001: {
|
||||
'name': 'Dummy Alliance 1',
|
||||
'ticker': 'DA1',
|
||||
'executor_corporation_id': 2001
|
||||
},
|
||||
3002: {
|
||||
'name': 'Dummy Alliance 2',
|
||||
'ticker': 'DA2'
|
||||
}
|
||||
}
|
||||
mock_result = Mock()
|
||||
if alliance_id in alliances:
|
||||
mock_result.result.return_value = alliances[alliance_id]
|
||||
return mock_result
|
||||
else:
|
||||
raise HTTPNotFound(Mock())
|
||||
|
||||
|
||||
@staticmethod
|
||||
def esi_get_alliances_alliance_id_corporations(alliance_id):
|
||||
alliances = {
|
||||
3001: [2001, 2002, 2003],
|
||||
3002: [2004, 2005]
|
||||
}
|
||||
mock_result = Mock()
|
||||
if alliance_id in alliances:
|
||||
mock_result.result.return_value = alliances[alliance_id]
|
||||
return mock_result
|
||||
else:
|
||||
raise HTTPNotFound(Mock())
|
||||
|
||||
|
||||
@staticmethod
|
||||
def esi_get_corporations_corporation_id(corporation_id):
|
||||
corporations = {
|
||||
2001: {
|
||||
'name': 'Dummy Corp 1',
|
||||
'ticker': 'DC1',
|
||||
'ceo_id': 1001,
|
||||
'member_count': 42,
|
||||
'alliance_id': 3001
|
||||
},
|
||||
2002: {
|
||||
'name': 'Dummy Corp 2',
|
||||
'ticker': 'DC2',
|
||||
'ceo_id': 1011,
|
||||
'member_count': 5
|
||||
}
|
||||
}
|
||||
mock_result = Mock()
|
||||
if corporation_id in corporations:
|
||||
mock_result.result.return_value = corporations[corporation_id]
|
||||
return mock_result
|
||||
else:
|
||||
raise HTTPNotFound(Mock())
|
||||
|
||||
|
||||
@staticmethod
|
||||
def esi_get_characters_character_id(character_id):
|
||||
characters = {
|
||||
1001: {
|
||||
'name': 'Bruce Wayne',
|
||||
'corporation_id': 2001,
|
||||
'alliance_id': 3001
|
||||
},
|
||||
1002: {
|
||||
'name': 'Peter Parker',
|
||||
'corporation_id': 2101
|
||||
}
|
||||
}
|
||||
mock_result = Mock()
|
||||
if character_id in characters:
|
||||
mock_result.result.return_value = characters[character_id]
|
||||
return mock_result
|
||||
else:
|
||||
raise HTTPNotFound(Mock())
|
||||
|
||||
|
||||
@staticmethod
|
||||
def esi_post_characters_affiliation(characters):
|
||||
character_data = {
|
||||
1001: {
|
||||
'corporation_id': 2001,
|
||||
'alliance_id': 3001
|
||||
},
|
||||
1002: {
|
||||
'corporation_id': 2101
|
||||
}
|
||||
}
|
||||
mock_result = Mock()
|
||||
if isinstance(characters, list):
|
||||
characters_result = list()
|
||||
for character_id in characters:
|
||||
if character_id in character_data:
|
||||
characters_result.append(character_data[character_id])
|
||||
else:
|
||||
raise HTTPNotFound(Mock())
|
||||
mock_result.result.return_value = characters_result
|
||||
return mock_result
|
||||
else:
|
||||
raise TypeError()
|
||||
|
||||
|
||||
@staticmethod
|
||||
def esi_get_universe_types_type_id(type_id):
|
||||
types = {
|
||||
4001: {
|
||||
'name': 'Dummy Type 1'
|
||||
},
|
||||
4002: {
|
||||
'name': 'Dummy Type 2'
|
||||
}
|
||||
}
|
||||
mock_result = Mock()
|
||||
if type_id in types:
|
||||
mock_result.result.return_value = types[type_id]
|
||||
return mock_result
|
||||
else:
|
||||
raise HTTPNotFound(Mock())
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.esi_client_factory')
|
||||
def test_str(self, mock_esi_client_factory):
|
||||
my_provider = EveSwaggerProvider()
|
||||
self.assertEqual(str(my_provider), 'esi')
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.esi_client_factory')
|
||||
def test_get_alliance(self, mock_esi_client_factory):
|
||||
mock_esi_client_factory.return_value\
|
||||
.Alliance.get_alliances_alliance_id \
|
||||
= TestEveSwaggerProvider.esi_get_alliances_alliance_id
|
||||
mock_esi_client_factory.return_value\
|
||||
.Alliance.get_alliances_alliance_id_corporations \
|
||||
= TestEveSwaggerProvider.esi_get_alliances_alliance_id_corporations
|
||||
|
||||
my_provider = EveSwaggerProvider()
|
||||
|
||||
# fully defined alliance
|
||||
my_alliance = my_provider.get_alliance(3001)
|
||||
self.assertEqual(my_alliance.id, 3001)
|
||||
self.assertEqual(my_alliance.name, 'Dummy Alliance 1')
|
||||
self.assertEqual(my_alliance.ticker, 'DA1')
|
||||
self.assertListEqual(my_alliance.corp_ids, [2001, 2002, 2003])
|
||||
self.assertEqual(my_alliance.executor_corp_id, 2001)
|
||||
|
||||
# alliance missing executor_corporation_id
|
||||
my_alliance = my_provider.get_alliance(3002)
|
||||
self.assertEqual(my_alliance.id, 3002)
|
||||
self.assertEqual(my_alliance.executor_corp_id, None)
|
||||
|
||||
# alliance not found
|
||||
with self.assertRaises(ObjectNotFound):
|
||||
my_provider.get_alliance(3999)
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.esi_client_factory')
|
||||
def test_get_corp(self, mock_esi_client_factory):
|
||||
mock_esi_client_factory.return_value\
|
||||
.Corporation.get_corporations_corporation_id \
|
||||
= TestEveSwaggerProvider.esi_get_corporations_corporation_id
|
||||
|
||||
my_provider = EveSwaggerProvider()
|
||||
|
||||
# corporation with alliance
|
||||
my_corp = my_provider.get_corp(2001)
|
||||
self.assertEqual(my_corp.id, 2001)
|
||||
self.assertEqual(my_corp.name, 'Dummy Corp 1')
|
||||
self.assertEqual(my_corp.ticker, 'DC1')
|
||||
self.assertEqual(my_corp.ceo_id, 1001)
|
||||
self.assertEqual(my_corp.members, 42)
|
||||
self.assertEqual(my_corp.alliance_id, 3001)
|
||||
|
||||
# corporation wo/ alliance
|
||||
my_corp = my_provider.get_corp(2002)
|
||||
self.assertEqual(my_corp.id, 2002)
|
||||
self.assertEqual(my_corp.alliance_id, None)
|
||||
|
||||
# corporation not found
|
||||
with self.assertRaises(ObjectNotFound):
|
||||
my_provider.get_corp(2999)
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.esi_client_factory')
|
||||
def test_get_character(self, mock_esi_client_factory):
|
||||
mock_esi_client_factory.return_value\
|
||||
.Character.get_characters_character_id \
|
||||
= TestEveSwaggerProvider.esi_get_characters_character_id
|
||||
mock_esi_client_factory.return_value\
|
||||
.Character.post_characters_affiliation \
|
||||
= TestEveSwaggerProvider.esi_post_characters_affiliation
|
||||
|
||||
my_provider = EveSwaggerProvider()
|
||||
|
||||
# character with alliance
|
||||
my_character = my_provider.get_character(1001)
|
||||
self.assertEqual(my_character.id, 1001)
|
||||
self.assertEqual(my_character.name, 'Bruce Wayne')
|
||||
self.assertEqual(my_character.corp_id, 2001)
|
||||
self.assertEqual(my_character.alliance_id, 3001)
|
||||
|
||||
# character wo/ alliance
|
||||
my_character = my_provider.get_character(1002)
|
||||
self.assertEqual(my_character.id, 1002)
|
||||
self.assertEqual(my_character.alliance_id, None)
|
||||
|
||||
# character not found
|
||||
with self.assertRaises(ObjectNotFound):
|
||||
my_provider.get_character(1999)
|
||||
|
||||
|
||||
@patch('allianceauth.eveonline.providers.esi_client_factory')
|
||||
def test_get_itemtype(self, mock_esi_client_factory):
|
||||
mock_esi_client_factory.return_value\
|
||||
.Universe.get_universe_types_type_id \
|
||||
= TestEveSwaggerProvider.esi_get_universe_types_type_id
|
||||
|
||||
my_provider = EveSwaggerProvider()
|
||||
|
||||
# type exists
|
||||
my_type = my_provider.get_itemtype(4001)
|
||||
self.assertEqual(my_type.id, 4001)
|
||||
self.assertEqual(my_type.name, 'Dummy Type 1')
|
||||
|
||||
# type not found
|
||||
with self.assertRaises(ObjectNotFound):
|
||||
my_provider.get_itemtype(4999)
|
||||
Loading…
x
Reference in New Issue
Block a user